Skip to content

Conversation

@Artmann
Copy link

@Artmann Artmann commented Nov 27, 2025

Summary by CodeRabbit

  • Chores

    • Renamed packages to the @deepnote scoped namespace and updated references, path mappings, and lint rules to match the new layout.
    • Added an automated continuous-delivery workflow to build and publish packages to npm on matching release tags, with per-package gating and validation.
    • Enabled composite TypeScript project settings for incremental/package-aware builds.
  • New Exports

    • Added a new publicly exported type (FixDescription) to the linting package.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2025

📝 Walkthrough

Walkthrough

Renames packages and imports from unscoped to @deepnote scope (e.g., sqlint@deepnote/sqlint, sql-language-server@deepnote/sql-language-server), adds FixDescription to sqlint's public exports, enables "composite": true in packages/sqlint tsconfig, updates TS path aliases, expands allowed modules in .eslintrc, and adds a new GitHub Actions "CD" workflow that parses release tags, validates package/version, builds affected package(s), and publishes scoped packages to npm using NPM_TOKEN.

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Actions
    participant Repo as Repository
    participant Runner as Action Runner (Node 18 + Yarn)
    participant npm as npm Registry

    note over GH,Repo: Trigger: release with tag "@deepnote/<pkg>@<ver>"
    GH->>Repo: checkout code
    GH->>Runner: setup Node 18 + Yarn cache
    Runner->>Repo: parse tag -> extract package & version
    alt invalid tag or unknown package
        Runner-->>GH: fail workflow (error)
    else valid package
        Runner->>Repo: verify package exists & package.json version matches
        Runner->>Runner: install dependencies
        Runner->>Repo: run package-specific build steps (if applicable)
        Runner->>npm: authenticate using NPM_TOKEN
        Runner->>npm: publish `@deepnote/<pkg>@<ver>`
        npm-->>Runner: publish response
        Runner->>GH: mark workflow success
    end
Loading

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: preparing packages for npm publication via scoping updates and CI/CD workflow.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3a92b6b and eb9a2fb.

📒 Files selected for processing (2)
  • .eslintrc.js (1 hunks)
  • tsconfig.json (1 hunks)
🔇 Additional comments (2)
tsconfig.json (1)

16-18: All imports already migrated—no breaking changes will occur.

The verification found no old unscoped imports in the codebase. The path aliases in tsconfig.json are internal workspace references within this monorepo (using Lerna). Since no code imports the old unscoped package names (sqlint, sql-language-server, sql-parser), removing those aliases will not break anything. The changes are safe.

.eslintrc.js (1)

26-26: Based on my verification, I can now provide the rewritten review comment:


Both "sql-language-server" entries serve different purposes and should likely both remain.

The allowModules list includes both "@deepnote/sql-language-server" (scoped) and "sql-language-server" (unscoped). These entries whitelist external packages for ESLint's node/no-missing-import rule. The upstream package is publicly available as "sql-language-server", while "@deepnote/sql-language-server" appears to be a Deepnote-scoped internal version. Without actual codebase imports of either variant, both entries represent defensive allowlisting for potential runtime dependencies. Removing the unscoped version could break if it's still referenced elsewhere or during a transition period between package sources.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Artmann Artmann merged commit 5a1ba0f into release Nov 27, 2025
2 checks passed
@Artmann Artmann deleted the chris/publish-packages-to-npm-workflow branch November 27, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants