-
Notifications
You must be signed in to change notification settings - Fork 2
chore: bump packages to 2.0.0 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe sql-parser package version in its package.json was changed from 1.7.5 to 2.0.0. The sqlint package version was bumped from 1.7.0 to 2.0.0 and its dependency on Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
🔇 Additional comments (2)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/server/package.json (1)
43-51: Inconsistent version constraints: sqlint dependency not updated.Server explicitly bumped @deepnote/sql-parser to ^2.0.0 (line 43), but @deepnote/sqlint is still pinned to ^1.7.0 (line 51). sqlint now depends on sql-parser ^2.0.0 (per its updated package.json), creating a potential version conflict or duplicate dependency tree.
Consider updating line 51 to match:
- "@deepnote/sqlint": "^1.7.0", + "@deepnote/sqlint": "^2.0.0",Or verify whether this constraint mismatch is intentional by checking whether sqlint actually published a 2.0.0 release.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
packages/server/package.json(2 hunks)packages/sqlint/package.json(1 hunks)
🔇 Additional comments (2)
packages/server/package.json (1)
72-72: Trailing newline added.packages/sqlint/package.json (1)
35-35: Based on my verification, I've gathered the following evidence:Key Findings:
sqlint heavily depends on @deepnote/sql-parser API: 8 source files import specific types (SelectStatement, BinaryExpressionNode, KeywordNode, parseAll, NodeRange, AST, Node, BaseNode)
Strong CI/CD safeguards in place: The GitHub Actions workflow includes:
- TypeScript compilation (
yarn vsc-compile:clientandyarn vsc-compile:server)- Comprehensive test suite (
yarn test:sqlintand others)- These would immediately catch any breaking API changes or missing types
No source code modifications evident: The imports remain unchanged, suggesting either:
- v2.0.0 maintains backward compatibility with these types, OR
- Breaking changes exist but weren't addressed
Cannot access sql-parser v2.0.0 documentation: The package appears to be private/internal to Deepnote, with no public changelog available
Verdict: The review comment's concern is valid and well-founded — a major version bump without visible code changes warrants verification. However, the presence of TypeScript compilation and functional tests in the CI pipeline means any actual breaking changes would be caught if tests pass. Without access to the PR's CI status or sql-parser's v2.0.0 changelog, the concern cannot be fully resolved through static analysis.
Verify that @deepnote/sql-parser v2.0.0 is compatible with sqlint's API usage. While the TypeScript compilation and test suite in CI should catch breaking changes, the lack of public documentation for @deepnote/sql-parser v2.0.0 and absence of visible source code updates raises valid concerns. Confirm this PR's CI/test results pass before merging.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.