Skip to content

Conversation

@Artmann
Copy link

@Artmann Artmann commented Nov 27, 2025

Summary by CodeRabbit

  • Chores
    • Released SQL Parser package version 2.0.0.
    • Bumped server and SQL linter components to use SQL Parser 2.0.0 and SQL linter 2.0.0.
    • Updated dependency references to the new 2.0.0 packages.
    • Minor manifest formatting cleanup (added trailing newline).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2025

📝 Walkthrough

Walkthrough

The sql-parser package version in its package.json was changed from 1.7.5 to 2.0.0. The sqlint package version was bumped from 1.7.0 to 2.0.0 and its dependency on @deepnote/sql-parser updated to ^2.0.0. The server package version was bumped from 1.7.0 to 2.0.0 and its dependencies updated to require @deepnote/sql-parser ^2.0.0 and @deepnote/sqlint ^2.0.0 (replacing the ^1.7.0 entries). No source code, runtime logic, or exported API signatures were modified.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately summarizes the main change—bumping multiple packages to version 2.0.0 across the monorepo.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9ae5f46 and 89cfe7b.

📒 Files selected for processing (2)
  • packages/server/package.json (3 hunks)
  • packages/sqlint/package.json (2 hunks)
🔇 Additional comments (2)
packages/sqlint/package.json (1)

3-3: Version and dependency updates align with monorepo.

Straightforward version bump to 2.0.0 and updated sql-parser dependency are consistent with the release.

Also applies to: 35-35

packages/server/package.json (1)

3-3: Version bump and cleanup look good.

Version, vscode-languageserver reordering, and trailing newline are in order—pending resolution of the breaking changes flagged above.

Also applies to: 56-56, 72-72


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/server/package.json (1)

43-51: Inconsistent version constraints: sqlint dependency not updated.

Server explicitly bumped @deepnote/sql-parser to ^2.0.0 (line 43), but @deepnote/sqlint is still pinned to ^1.7.0 (line 51). sqlint now depends on sql-parser ^2.0.0 (per its updated package.json), creating a potential version conflict or duplicate dependency tree.

Consider updating line 51 to match:

-    "@deepnote/sqlint": "^1.7.0",
+    "@deepnote/sqlint": "^2.0.0",

Or verify whether this constraint mismatch is intentional by checking whether sqlint actually published a 2.0.0 release.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2c1a7ca and 9ae5f46.

📒 Files selected for processing (2)
  • packages/server/package.json (2 hunks)
  • packages/sqlint/package.json (1 hunks)
🔇 Additional comments (2)
packages/server/package.json (1)

72-72: Trailing newline added.

packages/sqlint/package.json (1)

35-35: Based on my verification, I've gathered the following evidence:

Key Findings:

  1. sqlint heavily depends on @deepnote/sql-parser API: 8 source files import specific types (SelectStatement, BinaryExpressionNode, KeywordNode, parseAll, NodeRange, AST, Node, BaseNode)

  2. Strong CI/CD safeguards in place: The GitHub Actions workflow includes:

    • TypeScript compilation (yarn vsc-compile:client and yarn vsc-compile:server)
    • Comprehensive test suite (yarn test:sqlint and others)
    • These would immediately catch any breaking API changes or missing types
  3. No source code modifications evident: The imports remain unchanged, suggesting either:

    • v2.0.0 maintains backward compatibility with these types, OR
    • Breaking changes exist but weren't addressed
  4. Cannot access sql-parser v2.0.0 documentation: The package appears to be private/internal to Deepnote, with no public changelog available

Verdict: The review comment's concern is valid and well-founded — a major version bump without visible code changes warrants verification. However, the presence of TypeScript compilation and functional tests in the CI pipeline means any actual breaking changes would be caught if tests pass. Without access to the PR's CI status or sql-parser's v2.0.0 changelog, the concern cannot be fully resolved through static analysis.


Verify that @deepnote/sql-parser v2.0.0 is compatible with sqlint's API usage. While the TypeScript compilation and test suite in CI should catch breaking changes, the lack of public documentation for @deepnote/sql-parser v2.0.0 and absence of visible source code updates raises valid concerns. Confirm this PR's CI/test results pass before merging.

@Artmann Artmann changed the title chore: bump @deepnote/sql-parser to 2.0.0 chore: bump packages to 2.0.0 Nov 27, 2025
@Artmann Artmann merged commit eb6ba0f into release Nov 27, 2025
2 checks passed
@Artmann Artmann deleted the release-sql-parser-2.0.0 branch November 27, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants