Improvement for empty select statement & for catalog/database suggestions #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But only if no scoped columns were suggested
This will avoid suggesting tables when cursor is between SELECT and FROM. See new unit test
the21st
force-pushed
the
ss/better-empty-select-candidates
branch
from
3cba37f to
327ec03
Compare
the21st
changed the title
the21st
changed the title
ondrejromancov
approved these changes
Mar 24, 2023
ondrejromancov
left a comment
ondrejromancov
left a comment
There was a problem hiding this comment.
I didn't test these but code looks good to me!
| ) | ||
| if (!addedSome) { | ||
|
|
||
| const { addedSome: addedSomeScopedColumnCandidates } = |
petrfejfar
approved these changes
Mar 24, 2023
petrfejfar
left a comment
petrfejfar
left a comment
There was a problem hiding this comment.
Code looks good, I didn't test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits