-
Notifications
You must be signed in to change notification settings - Fork 4
chore: update Node.js version to 22.21.0 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
📝 WalkthroughWalkthroughNode.js version specifications in two .nvmrc files are updated. The root .nvmrc changes from 22.15.1 to 22.21.0, and the test folder .nvmrc changes from v20.17.0 to 22.21.0, standardizing both to the same version. Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-09-29T10:19:33.783ZApplied to files:
🔇 Additional comments (2)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 527 527
Lines 39474 39474
Branches 4933 4933
=====================================
Hits 28277 28277
Misses 9563 9563
Partials 1634 1634 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should get rid of telemetry tests before we reimplement them to work for deepnote notebooks. They currently are meant so send telemetry data reg. how fast jupyter block outputs for text, html, image render. There's also no ci check that runs them.
|
Admin merging |
Summary
Updates Node.js version to 22.21.0 in both
.nvmrcfiles:.nvmrc: 22.15.1 → 22.21.0 (minor version bump)src/test/vscode-notebook-perf/.nvmrc: v20.17.0 → 22.21.0 (major version jump)Context
Part of a Node version standardization across Deepnote repositories.
Link to Devin run: https://app.devin.ai/sessions/a8df8bf73298496b951e1c6812528db3
Requested by: James Hobbs (james@deepnote.com) / @jamesbhobbs
Review Checklist
src/test/vscode-notebook-perfshould be on Node 22 (was intentionally on Node 20)nvm use && npm install && npm testSummary by CodeRabbit
Chores