-
Notifications
You must be signed in to change notification settings - Fork 4
docs: update of the readme #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update of the readme #117
Conversation
|
Warning Rate limit exceeded@jamesbhobbs has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 23 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughREADME.md was rewritten into a feature-focused guide for the Deepnote multi-editor experience (VS Code, Cursor, Windsurf). The header was replaced with a cover image and badges. New sections include Requirements (VS Code, Python, Node.js), Getting Started, expanded Usage and Command Palette, Database integrations with secure credential handling, Working with SQL Blocks, Quick start for developers, Documentation links, License, support links, and a visual project showcase. No public API or exported declarations changed. Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant Editor as "Editor (VS Code / Cursor / Windsurf)"
participant Cmd as "Command Palette"
participant Ext as "Deepnote Extension"
participant Kernel as "Deepnote Kernel"
participant DB as "Database"
Note over Editor,Ext: Extension provides notebook blocks, SQL blocks,\nDB integrations, commands
User->>Editor: Open project/notebook
Editor->>Ext: Activate extension
User->>Cmd: Invoke command
Cmd->>Ext: Execute command
Ext->>Kernel: Load or run block
alt Connect to DB
Ext->>User: Prompt for credentials (secure store)
User->>Ext: Provide credentials
Ext->>DB: Establish connection
DB-->>Ext: OK / error
end
alt Run SQL block
User->>Ext: Run SQL block
Ext->>DB: Execute query
DB-->>Ext: Return rows / error
Ext->>Kernel: Render results
Kernel-->>User: Display results
else Run code block
User->>Ext: Run code block
Ext->>Kernel: Execute code
Kernel-->>User: Output / visualization
end
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
deepnote-dragon.pngis excluded by!**/*.png
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
🔇 Additional comments (3)
README.md (3)
48-48: Verify VS Code version requirement.VS Code 1.103.0 seems unusually high. Confirm this is the intended minimum version; typical stable releases are in the 1.9x range.
137-142: Documentation links verified—all files exist.All referenced documentation files are present in the repository:
architecture.md,DEEPNOTE_KERNEL_IMPLEMENTATION.md,INTEGRATIONS_CREDENTIALS.md, andCONTRIBUTING.md. The README.md links are valid.
79-81: Commands are implemented. All three commands are registered in the codebase:
'deepnote.newProject'(src/notebooks/deepnote/deepnoteExplorerView.ts:60)'deepnote.importNotebook'(src/notebooks/deepnote/deepnoteExplorerView.ts:64)Commands.ManageIntegrations(src/notebooks/deepnote/integrations/integrationManager.ts:33)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=====================================
Coverage 73% 73%
=====================================
Files 548 548
Lines 43272 43272
Branches 5256 5256
=====================================
Hits 31590 31590
Misses 9942 9942
Partials 1740 1740 🚀 New features to boost your workflow:
|
Removed header and duplicate image from README.
f9da621 to
837d120
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (1)
README.md (1)
1-1: Add H1 heading as first line to comply with MD041.This linting violation was flagged in the previous review. The file must start with a top-level heading, and the image should follow:
+# Deepnote VS Code Extension + - <!--- This is just placeholder for deepnote + vscodde logo ---> + <!--- This is just placeholder for deepnote + vscode logo --->This also fixes the typo
vscodde→vscodein the comment.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
deepnote-dragon.pngis excluded by!**/*.png
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
14-14: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above
(MD022, blanks-around-headings)
14-14: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build & Package Extension
- GitHub Check: Build & Test
- GitHub Check: Lint & Format
🔇 Additional comments (1)
README.md (1)
8-122: Comprehensive documentation improvements — well structured.The expanded README significantly improves the extension's onboarding experience with clear sections on features, requirements, getting started, usage, and developer resources. The promotional tone is appropriate and the technical content is accurate. Structure and formatting are professional once the linting issues above are resolved.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: James Hobbs <15235276+jamesbhobbs@users.noreply.github.com>
|
@jamesbhobbs Should I rebase with main before merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
deepnote-vscode-cover-image.pngis excluded by!**/*.png
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
14-14: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above
(MD022, blanks-around-headings)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
🔇 Additional comments (1)
README.md (1)
38-53: Clarify that Getting Started is VS Code-specific.The intro and header prominently feature VS Code, Cursor, and Windsurf equally, but the Getting Started section (lines 40–45) uses only VS Code-specific commands (
Cmd+P/Ctrl+P) and links exclusively to the VS Code Marketplace. Users of Cursor or Windsurf may be confused.Either add editor-specific subsections or note upfront that these steps apply to VS Code (and clarify whether the VS Code marketplace link works for the other editors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
130-130: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
jamesbhobbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Header still needs changing, will do in another PR
| Open the Command Palette (Command+Shift+P on macOS and Ctrl+Shift+P on Windows/Linux) and type in one of the following commands: | ||
| 1. Open VS Code | ||
| 2. Press `Cmd+P` or `Ctrl+P` to open Quick Open | ||
| 3. Type `ext install Deepnote.vscode-deepnote` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the default be using the UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Open the extensions tab and Search for Deepnote
- Or alternatively, press
Cmd+PorCtrl+Pto open the command palette. - Type `ext install Deepnote.vscode-deepnote
5f4992f
Co-authored-by: Christoffer Artmann <Artgaard@gmail.com>
Co-authored-by: Christoffer Artmann <Artgaard@gmail.com>
Summary by CodeRabbit