-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Fix dataframe output duplicate rendering #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomas Kislan <tomas@kislan.sk>
…erer Signed-off-by: Tomas Kislan <tomas@kislan.sk>
📝 WalkthroughWalkthroughThe PR consolidates the SQL integration identifier by replacing hard-coded strings with a centralized constant across notebook and test files. It refactors the webview-side dataframe rendering pipeline by introducing a new DataframeRendererContainer component that extracts and passes metadata to the underlying renderer, and adds an ErrorBoundary with ErrorFallback for error handling. The dispose function parameter is also renamed for consistency. Sequence Diagram(s)sequenceDiagram
participant index as index.ts
participant container as DataframeRendererContainer
participant renderer as DataframeRenderer
participant boundary as ErrorBoundary
Note over index,boundary: New Flow
index->>boundary: Render with outputJson,<br/>outputMetadata
boundary->>container: Props passed through
container->>container: Extract cellId &<br/>dataFrameMetadata
container->>renderer: Render with extracted<br/>metadata & data
renderer-->>container: Success
container-->>boundary: Rendered output
alt Error occurs
renderer-->>boundary: Error thrown
boundary->>boundary: Catch error
boundary->>boundary: Render ErrorFallback<br/>(message + stack)
end
Possibly related PRs
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (6)
🧰 Additional context used📓 Path-based instructions (6)**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/!(*.node|*.web).ts📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/notebooks/deepnote/**📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.unit.test.ts📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/platform/**/*.ts📄 CodeRabbit inference engine (.github/instructions/platform.instructions.md)
Files:
**/*.{test,spec}.ts📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)
Files:
🧬 Code graph analysis (4)src/notebooks/deepnote/deepnoteNotebookCommandListener.ts (1)
src/platform/notebooks/deepnote/sqlIntegrationEnvironmentVariablesProvider.unit.test.ts (1)
src/webviews/webview-side/dataframe-renderer/index.ts (2)
src/notebooks/deepnote/deepnoteNotebookCommandListener.unit.test.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (10)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 541 541
Lines 41481 41483 +2
Branches 5027 5027
=====================================
+ Hits 30209 30211 +2
Misses 9593 9593
Partials 1679 1679
🚀 New features to boost your workflow:
|
Artmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Signed-off-by: Tomas Kislan <tomas@kislan.sk>
Summary by CodeRabbit
New Features
Refactor