-
Notifications
You must be signed in to change notification settings - Fork 4
ci: Add package.lock drift check CI step #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomas Kislan <tomas@kislan.sk>
Signed-off-by: Tomas Kislan <tomas@kislan.sk>
📝 WalkthroughWalkthroughA new GitHub Actions job named "Package Lock Drift Check" is added to the CI workflow, configured to run after the Spell Check job. The job checks out the repository (actions/checkout v5), sets up Node.js (setup-node v6) with an npm registry scoped to @deepnote and npm cache, installs dependencies via Sequence Diagram(s)sequenceDiagram
autonumber
participant WF as Workflow
participant Spell as Spell Check Job
participant Drift as Package Lock Drift Check
participant Repo as Repository
participant Checkout as actions/checkout@v5
participant Node as actions/setup-node@v6
participant Npm as npm install
participant Git as git diff --exit-code HEAD
Note over Drift: timeout 5 minutes
WF->>Spell: run
Spell-->>WF: success
WF->>Drift: start (after Spell)
Drift->>Checkout: checkout repo (v5)
Checkout-->>Drift: code ready
Drift->>Node: setup-node (v6) + set npm registry for @deepnote + cache
Node-->>Drift: node/npm ready
Drift->>Npm: npm install (uses GITHUB_TOKEN)
Npm-->>Drift: deps installed (may modify lockfile)
Drift->>Git: git diff --exit-code HEAD
alt no changes
Git-->>Drift: exit 0 (pass)
Drift-->>WF: success
else changes detected
Git-->>Drift: exit non-zero (fail)
Drift-->>WF: failure
end
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
…ion in CI workflow Signed-off-by: Tomas Kislan <tomas@kislan.sk>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 545 545
Lines 41777 41777
Branches 5047 5047
=====================================
Hits 30431 30431
Misses 9665 9665
Partials 1681 1681 🚀 New features to boost your workflow:
|
Signed-off-by: Tomas Kislan <tomas@kislan.sk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
Signed-off-by: Tomas Kislan <tomas@kislan.sk>
jamesbhobbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor revision needed. Do this on other repos too please
Co-authored-by: James Hobbs <15235276+jamesbhobbs@users.noreply.github.com>
5d75213
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
193-217: Job structure and consistency look good.The workflow setup mirrors other jobs (checkout v5, setup-node v6, scoped npm registry, cache). The 5-minute timeout is appropriate. Permissions inherit the workflow-level defaults, which are sufficient (contents: read for git operations).
Example of failed CI run
https://github.com/deepnote/vscode-deepnote/actions/runs/18941121656/job/54079891655
Summary by CodeRabbit