Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/notebooks/deepnote/deepnoteDataConverter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ export class DeepnoteDataConverter {
for (const item of output.items) {
if (item.mime === 'text/plain') {
data['text/plain'] = new TextDecoder().decode(item.data);
} else if (item.mime === 'text/markdown') {
data['text/markdown'] = new TextDecoder().decode(item.data);
} else if (item.mime === 'text/html') {
data['text/html'] = new TextDecoder().decode(item.data);
} else if (item.mime === 'application/json') {
Expand Down Expand Up @@ -392,6 +394,10 @@ export class DeepnoteDataConverter {
);
}

if (data['text/markdown']) {
items.push(NotebookCellOutputItem.text(data['text/markdown'] as string, 'text/markdown'));
}

if (data['text/plain']) {
let mimeType = 'text/plain';
// deepnote-toolkit returns the text/plain mime type for big number outputs
Expand Down
40 changes: 40 additions & 0 deletions src/notebooks/deepnote/deepnoteDataConverter.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,46 @@ suite('DeepnoteDataConverter', () => {
const outputData = JSON.parse(new TextDecoder().decode(outputs[0].items[0].data));
assert.deepStrictEqual(outputData, sqlMetadata);
});

test('converts text/markdown output', () => {
const markdownContent = '## Result\n\nThis is **formatted** output.';

const deepnoteOutputs: DeepnoteOutput[] = [
{
output_type: 'execute_result',
execution_count: 1,
data: {
'text/markdown': markdownContent,
'text/plain': 'Result\n\nThis is formatted output.'
}
}
];

const blocks: DeepnoteBlock[] = [
{
blockGroup: 'test-group',
id: 'block1',
type: 'code',
content: 'display_markdown()',
sortingKey: 'a0',
outputs: deepnoteOutputs
}
];

const cells = converter.convertBlocksToCells(blocks);
const outputs = cells[0].outputs!;

assert.strictEqual(outputs.length, 1);
assert.strictEqual(outputs[0].items.length, 2);

const markdownItem = outputs[0].items.find((item) => item.mime === 'text/markdown');
const plainItem = outputs[0].items.find((item) => item.mime === 'text/plain');

assert.ok(markdownItem, 'Should have text/markdown item');
assert.ok(plainItem, 'Should have text/plain item');
assert.strictEqual(new TextDecoder().decode(markdownItem!.data), markdownContent);
assert.strictEqual(new TextDecoder().decode(plainItem!.data), 'Result\n\nThis is formatted output.');
});
});

suite('round trip conversion', () => {
Expand Down