Skip to content

Conversation

@saltenasl
Copy link
Member

@saltenasl saltenasl commented Oct 31, 2025

Summary by CodeRabbit

  • Refactor
    • The Jupyter Variables view has been relocated to sit inside the Deepnote view container for improved discoverability and streamlined navigation. Its name and activation behavior remain unchanged, so availability and functionality should be the same while appearing in the new nested location.

@saltenasl saltenasl requested a review from a team as a code owner October 31, 2025 12:23
@linear
Copy link

linear bot commented Oct 31, 2025

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The Jupyter Variables view contribution was relocated within package.json. It was removed from the top-level "views.jupyter-variables" entry and repositioned as a nested webview under the Deepnote "views" array, retaining the same id (jupyterViewVariables) and activation condition. No public API signatures were altered.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately describes the main changeset: moving the jupyterViewVariables view from a separate top-level view container into a nested webview under Deepnote. It's specific, concise, and uses conventional commit format with a clear action verb. The change directly addresses the issue indicated by the "warn-on-startup" scope, making the title fully representative of the structural reorganization performed in package.json.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5affbbc and 0123f70.

📒 Files selected for processing (1)
  • package.json (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73%. Comparing base (7cde864) to head (0123f70).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #148   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        548     548           
  Lines      43272   43272           
  Branches    5256    5256           
=====================================
  Hits       31590   31590           
  Misses      9942    9942           
  Partials    1740    1740           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saltenasl saltenasl enabled auto-merge (squash) October 31, 2025 16:43
@saltenasl saltenasl merged commit 137d31b into main Oct 31, 2025
12 of 13 checks passed
@saltenasl saltenasl deleted the lukas/grn-5040-fix-view-container-x-does-not-exist-errors-on-startup branch October 31, 2025 16:45
Artmann pushed a commit that referenced this pull request Oct 31, 2025
saltenasl added a commit that referenced this pull request Nov 1, 2025
…lete) (#88)

* feat: Set up a custom renderer for data frames.

* wip

* feat: Implement deepnote big number chart support and renderer

* refactor: Clean up debug logs and improve big number block conversion handling

* feat: Pass block metadata to cell outputs for renderer to access

* feat: Set up a custom renderer for data frames.

* wip

* add the table state.

* page size handling

* add page navigation

* Generate Python code before executing the cell.

* clean up

* pr feedback.

* Update build/esbuild/build.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat: Support Deepnote input blocks

* feat: Move DEEPNOTE_VSCODE_RAW_CONTENT_KEY into constants file

* feedback

* feat: Add Deepnote input blocks converters

* refactor: Remove debug logs and refine metadata parsing in Deepnote converters

* feat: Add chart big number converter tests

* Reformat test code

* Refactor ChartBigNumberBlockConverter tests to use deepStrictEqual for assertions

* Remove debug console.log

* docs and metadata changes.

* fix: Spread operator object fallback

* Merge remote-tracking branch 'origin/chris/display-data-frames' into tomaskislan/grn-4762-support-big-number-blocks

* use the latest blocks package.

* add the packages permission

* simplify execution flow.

* remove copyright header

* clean up the code

* revert controller changes

* pr feedback

* pr feedback

* fix the tests

* guard metadata spread against undefined.

* fix: Merge cleanup

* More merge cleanup

* Fix test

* feat: Add big number chart json config execution support

* feat: Add commands to add Deepnote SQL block and big number chart

* fix: Enhance error handling for big number metadata parsing and improve chart big number renderer logic

* refactor: Simplify chart big number renderer by directly rendering to the element and improve cleanup logic for unmounting components

* Fix import

* fix: Change deepnote_big_number_comparison_type to string type for better flexibility

* fix: Remove constants, accidentaly added to wrong branch

* Update package.json

* feat: Add new commands for SQL and Big Number Chart blocks

* feat: Update command titles and add SQL block functionality

* Fix imports

* fix: Fix imports

* fix: Remove unused code

* feat: Add support for new input blocks in Deepnote, including text, textarea, select, slider, checkbox, date, date range, file, and button blocks

* feat(big-number): Integrate react-error-boundary for error handling and enhance big number output rendering

* Update test snapshots

* feat: Update input create default values to match those in deepnote app

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* feat: Add support for project notebook management (create, rename, delete)

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* feat: Localize commands, extract notebook creation logic to reuse in methods

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* feat: Extract command ids into separate config files

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* refactor: Improve notebook renaming logic in DeepnoteExplorerView

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* refactor: Remove lowercase logic from notebook names checks

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* test: Implement DeepnoteExplorerView tests

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* fix: Fix spell check

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* test: Change assertion

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Revert "fix: Fix spell check"

This reverts commit 8becf4e.

* Revert "test: Change assertion"

This reverts commit fe81891.

* fix: Fix spellcheck

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* fix: Fix test yaml

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* test: Update assertions

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: Change version assertion from string to number

* fix: Fix version type in deepnote project unit test

* refactor: Reuse promptForNotebookName in rename command, simplify createAndAddNotebookToProject function

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* fix: Exclude current name from validation when renaming notebook

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* fix: Sort imports

Signed-off-by: Tomas Kislan <tomas@kislan.sk>

* feat(open-in-deepnote): button in toolbar (#153)

* feat(open-in-deepnote): button in toolbar

* chore: fix tests

* fix(warn-on-startup): move `jupyterViewVariables` view into the existing deepnote container (#148)

* feat: Order projects and notebooks alphabetically.

* fix: Don't recreate the tree.

* fix test

* fix dumb tests.

* coderabbit feedback

* more feedback

---------

Signed-off-by: Tomas Kislan <tomas@kislan.sk>
Co-authored-by: Christoffer Artmann <artgaard@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Lukas Šaltėnas <lukas.saltenas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants