-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Add support for Plotly charts. #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis PR adds Plotly v1 JSON chart output support to the Deepnote notebook converter, updates spell-check words for Plotly-related terms, declares a dependency/pack on Sequence Diagram(s)sequenceDiagram
autonumber
participant Deepnote as Deepnote blocks
participant Converter as DeepnoteDataConverter
participant VSCode as VS Code Notebook cells
rect rgb(230,245,255)
Note over Deepnote,Converter: Input parsing (convertBlocksToCells)
Deepnote->>Converter: execute_result with application/vnd.plotly.v1+json
Converter-->>VSCode: NotebookCell with output item mime: application/vnd.plotly.v1+json (json payload)
end
rect rgb(240,255,230)
Note over VSCode,Converter: Output serialization (convertCellsToBlocks)
VSCode->>Converter: NotebookCell containing NotebookCellOutputItem.json (plotly mime)
Converter-->>Deepnote: execute_result block with application/vnd.plotly.v1+json (identical payload)
end
Possibly related PRs
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🔇 Additional comments (1)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=====================================
Coverage 73% 73%
=====================================
Files 550 550
Lines 44004 44030 +26
Branches 5312 5314 +2
=====================================
+ Hits 32189 32215 +26
Misses 10048 10048
Partials 1767 1767
🚀 New features to boost your workflow:
|
saltenasl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outputs are now rendered correctly after reloading the vscode window, thanks!
Summary by CodeRabbit
New Features
Tests
Chores