Skip to content

fix: init notebook execution on windows #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

fix: init notebook execution on windows #166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b83ed
fix: init notebook execution on windows
FilipPyrek Nov 3, 2025
c8086dc
Merge branch 'main' into fpyrek/BLU-5107-1762181011
saltenasl Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/notebooks/deepnote/deepnoteInitNotebookRunner.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,22 @@ import type { DeepnoteProject, DeepnoteNotebook } from '../../platform/deepnote/
import { IKernelProvider } from '../../kernels/types';
import { getDisplayPath } from '../../platform/common/platform/fs-paths';

const DEEPNOTE_CLOUD_INIT_NOTEBOOK_BLOCK_CONTENT = `%%bash
# If your project has a 'requirements.txt' file, we'll install it here.
if test -f requirements.txt
then
pip install -r ./requirements.txt
else echo "There's no requirements.txt, so nothing to install."
fi`.trim();

const VSCODE_INIT_NOTEBOOK_BLOCK_CONTENT = `import os, sys, subprocess

if os.path.exists("requirements.txt"):
print("Installing requirements.txt")
subprocess.run([sys.executable, "-m", "pip", "install", "-r", "requirements.txt"], check=False)
else:
print("There's no requirements.txt, so nothing to install.")`.trim();

/**
* Service responsible for running init notebooks before the main notebook starts.
* Init notebooks typically contain setup code like pip installs.
Expand Down Expand Up @@ -253,8 +269,20 @@ export class DeepnoteInitNotebookRunner {
logger.info(`Executing init notebook block ${i + 1}/${codeBlocks.length}`);

try {
// Make sure the init notebook execution works cross-platform
let blockContent = block.content ?? '';
const isWindows = process.platform === 'win32';
if (isWindows && blockContent.trim() === DEEPNOTE_CLOUD_INIT_NOTEBOOK_BLOCK_CONTENT) {
blockContent = VSCODE_INIT_NOTEBOOK_BLOCK_CONTENT;
logger.info(
`Replacing Deepnote Cloud init notebook block ${
i + 1
} content with VSCode init notebook block`
);
}

// Execute the code silently in the background
const outputs = await kernelExecution.executeHidden(block.content ?? '');
const outputs = await kernelExecution.executeHidden(blockContent);

// Log outputs for debugging
if (outputs && outputs.length > 0) {
Expand Down
Loading