-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Rendering of empty data table cells #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a minimum height class ( Suggested reviewers
Pre-merge checks✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🔇 Additional comments (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx(1 hunks)
🔇 Additional comments (1)
src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx (1)
156-160: LGTM: min-height ensures consistent row heights.The
min-h-[16px]class prevents cells from collapsing when empty or containing short content.
src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=====================================
Coverage 73% 73%
=====================================
Files 574 574
Lines 46813 46813
Branches 5519 5519
=====================================
Hits 34358 34358
Misses 10637 10637
Partials 1818 1818 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Bug Fixes
Style