Skip to content

Conversation

@jankuca
Copy link
Member

@jankuca jankuca commented Nov 4, 2025

Screenshot 2025-11-04 at 11 24 18

Summary by CodeRabbit

  • Bug Fixes

    • Consistently display null and undefined values as "None"
    • Improved fallback rendering to ensure reliable cell content display
  • Style

    • Added a minimum height to data cells for more consistent layout

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

📝 Walkthrough

Walkthrough

Adds a minimum height class (min-h-[16px]) to each rendered dataframe cell and simplifies null/undefined handling by using a loose equality check (value == null). Cells render the literal None for null or undefined; otherwise they render String(value). No changes to row background alternation or other rendering logic.

Suggested reviewers

  • Artmann

Pre-merge checks

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title directly relates to the main change: adding minimum height to data cells and fixing null/undefined rendering in the DataframeRenderer component.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d223a7b and 571bc66.

📒 Files selected for processing (1)
  • src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx (1 hunks)
🔇 Additional comments (1)
src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx (1)

156-160: Min-height fix addresses empty cell collapse.

Adding min-h-[16px] ensures empty cells remain visible and properly bordered.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dab37cb and d223a7b.

📒 Files selected for processing (1)
  • src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx (1 hunks)
🔇 Additional comments (1)
src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx (1)

156-160: LGTM: min-height ensures consistent row heights.

The min-h-[16px] class prevents cells from collapsing when empty or containing short content.

jankuca and others added 2 commits November 4, 2025 11:35
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@jankuca jankuca marked this pull request as ready for review November 4, 2025 10:42
@jankuca jankuca requested a review from a team as a code owner November 4, 2025 10:42
@saltenasl saltenasl enabled auto-merge (squash) November 4, 2025 12:40
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73%. Comparing base (7ad3d78) to head (8e2a15f).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #171   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        574     574           
  Lines      46813   46813           
  Branches    5519    5519           
=====================================
  Hits       34358   34358           
  Misses     10637   10637           
  Partials    1818    1818           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saltenasl saltenasl merged commit b47df83 into main Nov 4, 2025
13 checks passed
@saltenasl saltenasl deleted the jk/fix/data-table-empty-cell branch November 4, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants