fix: Use 'json' as language name when parsing chart block from file

[OlegWock]

Summary by CodeRabbit

• Bug Fixes
  • Corrected language identifier formatting for visualization block cells.

[linear]

BLU-5116 Chart block exported from Deepnote into .deepnote file is not executable in VSC extension

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated the language identifier for visualization block cells from 'JSON' to 'json' in the converter implementation. The corresponding unit test was updated to match the new expectation. This change affects how the cell content is identified but does not alter conversion logic or file structure.

Pre-merge checks

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title directly reflects the core change: updating language hint from 'JSON' to 'json' in visualization block parsing.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dab37cb and d9b72fc.

📒 Files selected for processing (2)

• src/notebooks/deepnote/converters/visualizationBlockConverter.ts (1 hunks)
• src/notebooks/deepnote/converters/visualizationBlockConverter.unit.test.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{test,spec}.ts

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

In unit tests, when a mock is returned from a promise, ensure the mocked instance has an undefined then property to avoid hanging tests

Files:

• src/notebooks/deepnote/converters/visualizationBlockConverter.unit.test.ts

🧬 Code graph analysis (1)

src/notebooks/deepnote/converters/visualizationBlockConverter.ts (1)

src/test/mocks/vsc/extHostedTypes.ts (1)

• NotebookCellData (2546-2572)

🔇 Additional comments (2)

src/notebooks/deepnote/converters/visualizationBlockConverter.unit.test.ts (1)

62-62: Test correctly updated to expect lowercase 'json'.

Matches the implementation change and uses the proper VS Code language identifier.

src/notebooks/deepnote/converters/visualizationBlockConverter.ts (1)

87-87: Correct fix: VS Code expects lowercase language identifiers.

Using 'json' instead of 'JSON' ensures proper syntax highlighting and language support.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73%. Comparing base (dab37cb) to head (d9b72fc).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #173   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        574     574           
  Lines      46813   46813           
  Branches    5519    5519           
=====================================
  Hits       34358   34358           
  Misses     10637   10637           
  Partials    1818    1818           

Files with missing lines	Coverage Δ
...deepnote/converters/visualizationBlockConverter.ts	100% <100%> (ø)
...onverters/visualizationBlockConverter.unit.test.ts	100% <100%> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[saltenasl]

works, well, thanks!