fix(deps): Address npm security advisories#327
Conversation
diff (GHSA-73rr-hh4g-fpgx) - Fixed via overrides: - Override diff to 5.2.2 under mocha and sinon (patch bump, ^5.x range) - Override diff to 4.0.4 under tslint (patch bump, ^4.x range) - Removes the .nsprc exception since the vulnerability is now resolved eslint RuleTester (GHSA-p5wg-g6qr-c7cg) - Removed: - Advisory was withdrawn in Feb 2026, exception no longer needed tar (GHSA-83g3-92jg-28cx) - Fixed via override bump: - Bump tar override from 7.5.7 to 7.5.8 (patch fix) elliptic (GHSA-848j-6mx2-7j84) - Exception retained: - No fix available, dev-only transitive dep, not used for signing - Extended expiry to 2026-08-15 undici (GHSA-g9mf-h72j-4rw9) - Exception retained: - Fix requires major version jump (5.x -> 7.x) breaking @actions/http-client - Extended expiry to 2026-08-15 ajv (GHSA-2g4f-4pwh-qvx6) - New exception: - Fix requires ajv@8.x but consumers (@jupyterlab/settingregistry, table) are on 6.x - Dev-only, not bundled in extension minimatch (GHSA-3ppc-4f35-3m26) - New exception: - Fix requires minimatch@10.x but consumers (mocha, glob) are on 3.x-5.x - Dev-only, not bundled in extension
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughUpdates security advisory records in 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
The audit-prod CI job used raw `npm audit --production` which doesn't read .nsprc exceptions, causing failures for accepted-risk advisories (ajv, minimatch). Switch to `better-npm-audit audit --production` to match audit-all and respect the shared exceptions file.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 216-217: Pin the better-npm-audit tool to a specific version
instead of calling it unpinned with npx; update the CI run step that currently
uses "npx better-npm-audit audit --production" to either call "npx
better-npm-audit@<stable-version> audit --production" or add better-npm-audit as
a devDependency and invoke it via "npm exec better-npm-audit audit --production"
to ensure reproducibility and supply-chain safety.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
===========================
===========================
🚀 New features to boost your workflow:
|
diff (GHSA-73rr-hh4g-fpgx) - Fixed via overrides:
eslint RuleTester (GHSA-p5wg-g6qr-c7cg) - Removed:
tar (GHSA-83g3-92jg-28cx) - Fixed via override bump:
elliptic (GHSA-848j-6mx2-7j84) - Exception retained:
undici (GHSA-g9mf-h72j-4rw9) - Exception retained:
ajv (GHSA-2g4f-4pwh-qvx6) - New exception:
minimatch (GHSA-3ppc-4f35-3m26) - New exception:
Summary by CodeRabbit