Skip to content

fix(codecov-for-dependabot): use oidc when uploading test results to codecov #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
Merged

fix(codecov-for-dependabot): use oidc when uploading test results to codecov #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ee4226
fix(codecov-for-dependabot): use oidc when uploading test results to …
saltenasl Oct 14, 2025
b53d3d2
fix(codecov-for-dependabot): also fix upload coverage
saltenasl Oct 14, 2025
41fbc4a
Merge branch 'main' into ls/fix-codecov-for-dependabot
saltenasl Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ jobs:
name: Build & Test
runs-on: ubuntu-latest
timeout-minutes: 15
permissions:
id-token: write
contents: read
steps:
- name: Checkout
uses: actions/checkout@v5
Expand Down Expand Up @@ -121,16 +124,16 @@ jobs:
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
use_oidc: true
files: coverage/lcov.info
fail_ci_if_error: true

- name: Upload test results to Codecov
if: '!cancelled()'
uses: codecov/test-results-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: test-report.xml
use_oidc: true
files: test-results.xml
Copy link
Member Author

@saltenasl saltenasl Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/deepnote/vscode-deepnote/actions/runs/18408169266/job/52453078649?pr=26#step:8:34

Copy link
Contributor

@jamesbhobbs jamesbhobbs Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can omit the line entirely and it'd be fine.

fail_ci_if_error: true

- name: Check dependencies
Expand Down