Remove duplicate build job from CI workflow #95
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
buildjob from the CI workflow (ci.yml) to eliminate perceived duplication with the CD workflow.Changes
The following build job was removed from
.github/workflows/ci.yml:npm run compile)npm test)npm run checkDependencies)npm run check-licenses)Note: License checking is preserved via the separate
check_licensesjob that remains in the CI workflow.Please verify before merging:
Are tests still being executed?
npm testIs code coverage still being uploaded to Codecov?
Is dependency checking still happening?
npm run checkDependenciesruns elsewhereDoes the CD workflow actually run a full build?
Context
Requested by James Hobbs (james@deepnote.com) / @jamesbhobbs to remove duplication between CI and CD workflows.
Devin run: https://app.devin.ai/sessions/3b7b4414be8845d1bde6d8fedb3c734d
Summary by CodeRabbit