Skip to content

Conversation

@jamesbhobbs
Copy link
Contributor

Summary

This PR updates the qlty job in the CI workflow to fetch full git history by adding fetch-depth: 0 to the checkout action. This ensures qlty has access to the complete git history, which is required for it to properly analyze code changes and compare against previous commits/branches.

Changes

  • .github/workflows/ci.yml:
    • Added fetch-depth: 0 to the checkout step in the qlty job
    • Updated checkout action to v5 (standardizing with the pinned SHA)

Why This Change?

By default, actions/checkout performs a shallow clone with limited history. Qlty relies on having access to the full git history to:

  • Compare code against the base branch
  • Detect changes accurately
  • Provide meaningful code quality feedback

Without fetch-depth: 0, qlty may produce inaccurate results or fail to detect changes properly.

Testing

⚠️ This change can only be validated through CI runs. Please verify:

  • All CI checks pass
  • Qlty check and qlty smells jobs complete successfully
  • No significant increase in CI duration

Related

This is part of a broader effort to standardize qlty checkout configuration across all Deepnote repositories (jupyterlab-deepnote, deepnote, deepnote-internal, vscode-deepnote).


Link to Devin run: https://app.devin.ai/sessions/8e83a17c48d34c79be89b985c9b936ee
Requested by: James Hobbs (james@deepnote.com) / @jamesbhobbs

@devin-ai-integration
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

Warning

Rate limit exceeded

@jamesbhobbs has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e6c8338 and de92798.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@jamesbhobbs jamesbhobbs marked this pull request as ready for review October 20, 2025 19:01
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71%. Comparing base (e6c8338) to head (de92798).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #96   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        523     523           
  Lines      39001   39001           
  Branches    4905    4905           
=====================================
  Hits       27834   27834           
  Misses      9542    9542           
  Partials    1625    1625           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jamesbhobbs jamesbhobbs merged commit 9e00675 into main Oct 20, 2025
12 checks passed
@jamesbhobbs jamesbhobbs deleted the devin/1760986785-fix-qlty-checkout-fetch-depth branch October 20, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants