어드민 멤버 세팅 수정 api에서 프로필 공개 여부, 활동 상태 설정 제거

[hainho]

Summary by CodeRabbit

• Refactor
  • 관리자용 회원 설정 업데이트가 단순화되었습니다 — 프로필 공개 여부와 활동 상태 옵션이 제거되고, 등급·VIP 여부·푸시 수신 설정만으로 변경됩니다.
• Tests
  • 해당 변경에 맞춰 관련 테스트들이 업데이트되어 동작과 이벤트 발생을 검증하도록 조정되었습니다.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

노트

• 어드민 멤버 세팅 수정 api에서 프로필 공개 여부, 활동 상태 설정 제거

[coderabbitai]

Walkthrough

이 변경은 member 설정 업데이트에서 두 개의 파라미터를 제거한 리팩토링입니다. Member.updateSetting() 시그니처에서 isProfilePublic과 activityStatus가 삭제되었고, 관련 DTO(AdminMemberSettingUpdateRequest), 서비스(AdminMemberService), 도메인(Member) 및 테스트 코드들이 이에 맞춰 수정되었습니다. 남은 인자는 grade, isVip, isPushNotificationEnabled입니다. 이벤트 발생(Events.raise(MemberSettingUpdatedEvent)) 관련 호출은 테스트에서 검증하도록 조정되었습니다.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	PR 설명은 필수 섹션 구조를 갖추고 있으나, 변경 사항의 세부 내용과 영향 범위에 대한 설명이 부족합니다.	변경 동기, 영향받는 API 엔드포인트, 마이그레이션 가이드 등 추가 context를 제공하여 설명을 보완해주세요.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	PR 제목은 API에서 프로필 공개 여부와 활동 상태 설정을 제거한 변경사항을 명확하게 요약하고 있으며, 실제 코드 변경과 정확히 일치합니다.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch issue/407

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java (1)

174-189: isPushNotificationEnabled parameter에 대한 assertion이 누락되었습니다.

Line 181에서 isPushNotificationEnabled = false를 설정하고 updateSetting에 전달하지만, assertion에서 이 값이 올바르게 적용되었는지 검증하지 않습니다. 테스트의 완전성을 위해 해당 parameter도 검증해야 합니다.

💚 Proposed fix

         // Then
         Assertions.assertThat(member.getGrade()).isEqualTo(grade);
         Assertions.assertThat(member.isVip()).isEqualTo(isVip);
+        Assertions.assertThat(member.isPushNotificationEnabled()).isEqualTo(isPushNotificationEnabled);
     }

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8ccf79 and 04db81b.

📒 Files selected for processing (5)

• src/main/java/deepple/deepple/member/command/application/member/AdminMemberService.java
• src/main/java/deepple/deepple/member/command/domain/member/Member.java
• src/main/java/deepple/deepple/member/presentation/member/dto/AdminMemberSettingUpdateRequest.java
• src/test/java/deepple/deepple/member/command/application/member/AdminMemberServiceTest.java
• src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java

💤 Files with no reviewable changes (3)

• src/main/java/deepple/deepple/member/command/domain/member/Member.java
• src/main/java/deepple/deepple/member/presentation/member/dto/AdminMemberSettingUpdateRequest.java
• src/main/java/deepple/deepple/member/command/application/member/AdminMemberService.java

🧰 Additional context used

📓 Path-based instructions (2)

**/*.java

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.java: Use JPA with QueryDSL for persistence, MySQL with Flyway for migrations, JWT tokens and Spring Security for authentication, and Redis with Redisson for caching in Java Spring Boot files
Implement domain events using the local event system (Events.java) for domain event handling, with events published and handled within the same process by event handlers in the infrastructure layer
Use Lombok to reduce boilerplate in Java domain entities
Use value objects heavily for domain modeling in Java domain layer
Abstract all external API calls through domain interfaces in Java code
Project uses Java 21 language features in all Java code

Files:

• src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java
• src/test/java/deepple/deepple/member/command/application/member/AdminMemberServiceTest.java

---

⚙️ CodeRabbit configuration file

**/*.java: In addition to existing rules, review code based on: - Domain-driven design: enforce aggregate boundaries and immutable value objects - Clean code: single responsibility methods, meaningful names, no duplication - Object-oriented programming: SOLID(SRP, OCP, LSP, ISP, DIP) principles - Performance and scalability: consider high traffic scenarios, database query optimization, proper indexing, caching strategies, connection pool management, and async processing where appropriate

Files:

• src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java
• src/test/java/deepple/deepple/member/command/application/member/AdminMemberServiceTest.java

**/*Test.java

📄 CodeRabbit inference engine (CLAUDE.md)

Write unit tests for domain objects and value objects, integration tests for repositories using @DataJpaTest, and service tests using mocks and test slices, following the same package structure as main code

Files:

• src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java
• src/test/java/deepple/deepple/member/command/application/member/AdminMemberServiceTest.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: test

🔇 Additional comments (2)

src/test/java/deepple/deepple/member/command/application/member/AdminMemberServiceTest.java (2)

31-45: LGTM!

테스트가 새로운 API signature와 올바르게 정렬되었습니다. AdminMemberSettingUpdateRequest의 3-parameter constructor 사용과 updateSetting verification이 PR objectives에 맞게 수정되었습니다.

---

47-61: LGTM!

Exception test case도 업데이트된 DTO constructor를 올바르게 사용하고 있습니다.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[github-actions]

Test results

780 tests   780 ✅  14s ⏱️
235 suites    0 💤
235 files      0 ❌

Results for commit d1b9ce2.

♻️ This comment has been updated with latest results.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java`:
- Around line 191-194: The test uses identity comparison (==) for Long in
eventsMock.verify for Events.raise, which can misrepresent intent; update the
predicate in MemberTest (the Events.raise verification for
MemberSettingUpdatedEvent) to perform value equality for getMemberId() — e.g.,
use Objects.equals(((MemberSettingUpdatedEvent) event).getMemberId(), memberId)
or compare primitive long values via .longValue() — so the assertion checks the
Long value equality rather than reference identity.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04db81b and d1b9ce2.

📒 Files selected for processing (1)

• src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java

🧰 Additional context used

📓 Path-based instructions (2)

**/*.java

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.java: Use JPA with QueryDSL for persistence, MySQL with Flyway for migrations, JWT tokens and Spring Security for authentication, and Redis with Redisson for caching in Java Spring Boot files
Implement domain events using the local event system (Events.java) for domain event handling, with events published and handled within the same process by event handlers in the infrastructure layer
Use Lombok to reduce boilerplate in Java domain entities
Use value objects heavily for domain modeling in Java domain layer
Abstract all external API calls through domain interfaces in Java code
Project uses Java 21 language features in all Java code

Files:

• src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java

---

⚙️ CodeRabbit configuration file

**/*.java: In addition to existing rules, review code based on: - Domain-driven design: enforce aggregate boundaries and immutable value objects - Clean code: single responsibility methods, meaningful names, no duplication - Object-oriented programming: SOLID(SRP, OCP, LSP, ISP, DIP) principles - Performance and scalability: consider high traffic scenarios, database query optimization, proper indexing, caching strategies, connection pool management, and async processing where appropriate

Files:

• src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java

**/*Test.java

📄 CodeRabbit inference engine (CLAUDE.md)

Write unit tests for domain objects and value objects, integration tests for repositories using @DataJpaTest, and service tests using mocks and test slices, following the same package structure as main code

Files:

• src/test/java/deepple/deepple/member/command/domain/member/MemberTest.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: test

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}