docs: development.md prerequisites omit the C toolchain requirement (node-pty is a boot-time hard dependency) #1548
coderdailyone
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What happened: On a Linux host without
make/gcc(and without root to installbuild-essential),pnpm installfails atnode-pty@1.1.0's node-gyp build (gyp ERR! stack Error: not found: make). The upstream tarball ships prebuilds only for win32, so Linux/macOS always compile.Setting
allowBuilds: node-pty: falselocally lets install finish, but the harness then fails loud at boot:dsh-subprocess-localimports node-pty at module top level, so every profile (including headless) refuses to start without the native binary — which is consistent with the misconfiguration-fails-loud stance, but means the toolchain is a hard prerequisite, not an optional extra for terminal features.The gap:
docs/development.mdprerequisites list Node, pnpm/Corepack, and Git, but not a C toolchain. A fresh contributor on a minimal host discovers the requirement only at the bottom of a failed install.Suggestions (either or both):
build-essential/ Xcode CLT) is required on Linux/macOS fornode-pty's native build.@lydell/node-ptypublishes prebuilt binaries and tracks upstream versions exactly (its1.1.0matches your pin; I verified the linux-x64pty.nodedrop-in loads and spawns correctly throughdsh-subprocess-local, and the full web profile boots and serves with it). Given the repo already patches node-pty, shipping or documenting a prebuild path could remove the toolchain requirement for users who only consume dsh.Environment: Ubuntu 22.04, Node v24.18.0, pnpm 11.7.0, commit
47f9438. Happy to provide full logs.All reactions