[Proposal] propagate the repo-declared engines field into published @deepseek-ai/* manifests #2259
Replies: 2 comments
|
Strong ask, and I want to correct one premise in it, since the "nothing upstream to arbitrate" line is mine and I was wrong when I wrote it. It is declared, and not only in // package.json, line 8
"engines": {
"node": "^22.19.0 || >=24.0.0"
},https://github.com/deepseek-ai/deepseek-harness/blob/47f9438/package.json#L8-L10 That changes what this issue is asking for, in a way that should make it easier to land. It is not a request to decide a floor. The floor exists, it is machine-readable, and it is already the source of truth for anyone developing in the repo. The request is only that the published manifests carry the value the repo already declares. The gap is real and worth fixing exactly as you propose. Of the 61 published Two things follow from propagating it. Installers get the One correction to the evidence line while we are here.
|
|
+1 from moonquake2004/dsh-doctor (one of the three converging implementations from #1719). This propagation is exactly what lets our Two small implementation notes, in case they help land it:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Refined ask (thanks to @sjh9714's correction): propagate the already-declared Node floor into the published package manifests.
Original premise corrected: the floor EXISTS and is machine-readable — the monorepo root package.json declares it at line 8:
The gap is distribution, not definition: of the 61 published @deepseek-ai/* packages, only node-addon-landlock-run carries an engines field. The constraint is enforced for contributors and invisible to users.
Propagating it gives two concrete wins:
Evidence:
npm view @deepseek-ai/dsh@0.1.0-rc.6 engines→ (empty); root package.json line 8 declares the range.All reactions