[Bug] dsh plugin add does not reconcile when pnpm returns non-zero exit code

[Mby159]

When dsh plugin add installs a plugin from GitHub and pnpm returns non-zero exit code (e.g., a blocked prepare script with pnpm 10), the plugin package installs to node_modules but reconcilePlugins is skipped. This means the bundle never appears in dsh.profile.bundles and the plugin cordis.patch.yml is never merged on startup.

The fix is in apps/cli/src/plugin.ts in the runPlugin() function. When pnpm returns non-zero, check if the package exists in node_modules. If it does, call reconcilePlugins anyway so the bundle list is still updated.

Proposed code:

if (exitCode !== 0) {
const pkgPath = join(dir, 'node_modules', packageName)
if (existsSync(join(pkgPath, 'package.json'))) reconcilePlugins(before, dir)
}

This handles the case where the package installed successfully but pnpm returned non-zero due to allowBuilds or similar issues. Source: apps/cli/src/plugin.ts

[denial123789]

Verified on rc.8 (141eb6f): runPlugin() calls reconcilePlugins(before, dir) only for exitCode === 0, so a nonzero pnpm result can leave dependency state materialized while the bundle list remains unchanged.

One safety caveat for the proposed existence check: node_modules/<name>/package.json proves materialization, not a completed prepare. A blocked Git build can leave the manifest while exports, dist/, lib/, or the dsh.bundle.patch target is missing; reconciling that package immediately can turn the install diagnostic into a profile boot failure. If DSH treats a nonzero transaction as recovered success, the postcondition should validate dependency ownership, exact resolution, bundle declaration, patch target, and runtime exports, and should report that recovered-success state explicitly. Otherwise the safest supported flow is to preserve the old bundle list, fix the exact allowBuilds cause, and rerun the original command to a zero exit.

I documented the five distinct states (materialized, dependency-recorded, built, reconciled, bootable), operator retry/rollback paths, and a 12-gate regression matrix here: https://sandbaseai.github.io/deepseek-harness-handbook/plugin-add-nonzero-reconcile.html