Replies: 1 comment
|
This is fixed on current master. I re-ran the gate to confirm rather than inferring it from the anchor text. Verified at master Both anchors you reported are gone:
Version boundary. You tested Your second point still stands, and it is the part worth fixing separately: If this answers it, marking it as the answer would help the next person who finds the same stale-anchor output. |
Uh oh!
There was an error while loading. Please reload this page.
pnpm run hygienefails on a fresh clone ofmasterbecause two of theEXACT_EDITSinscripts/rescope-vendor.tsanchor to text that no longer exists in the repository. Both anchors were removed by unrelated commits that did not update the edit list, and no CI mode runs this gate, so nothing caught it.Reproduction
Fresh worktree at
master(b150a551b8), freshpnpm install --frozen-lockfile, Node 24, pnpm 11.7.0:pnpm run hygienefails on the same gate (FAILED vendor rescope). Nothing else in the gate is wrong —pnpm run check:ci:staticis 37/37 green on the same tree, which is consistent with this gate being outside CI.Cause
knip-logger-consoleanchors to anignoreDependenciesblock immediately followed by the"packages/util/home"key:50c22ee472("chore(knip): drop stale and glob-duplicate workspace entries") removed thepackages/util/homeentry fromknip.json.@cordisjs/plugin-logger-consoleno longer appears anywhere inknip.jsoneither, so the edit has nothing left to do — the vendored package is already rescoped to@deepseek-ai/cordis-plugin-logger-consoleand is covered by the@deepseek-ai/.+pattern beside it. That commit did not touchscripts/rescope-vendor.ts.vendoring-cookbook-name-invariant-zhexpects its replacement text to link../rescope.md:8d3674695b("docs(i18n): localize Chinese internal links") changed the applied text indocs/cookbook/adding-a-vendored-package.zh.mdto link../rescope.zh.md, which is what the pairing contract's link-locale rule requires. The edit is substantively applied; only itsreplacestring is stale. That commit also did not touchscripts/rescope-vendor.ts.In both cases
exactEditStatesees neitherfindnorreplace, so it reportsinvalidrather thanpendingorapplied.Why it went unnoticed
rescope-vendor:checkis reachable only throughhygieneLeafGates()inscripts/run-gates.ts, which is included by thehygieneandcheck-allmodes. Neither is a CI mode —ci-static,ci-primary, and the rest never call it. So the gate runs only when a contributor invokespnpm run hygienelocally, and both anchors could rot without any signal.That orchestration gap may be the more interesting half of this report: a gate that no CI mode executes will drift silently, and this one is load-bearing for the vendoring workflow.
Fix
Retiring the obsolete
knip-logger-consoleedit and pointing the zh cookbook edit at../rescope.zh.mdrestores the gate:Happy to share the diff if it's useful, though I understand from
CONTRIBUTING.mdthat external pull requests aren't being accepted right now — so this is a report rather than a patch offer. Either way, adding the gate to a CI mode would stop the next anchor from rotting.Environment: macOS 15 (arm64), Node 24.18.0, pnpm 11.7.0,
masteratb150a551b8.All reactions