Contribution proposal: local search in the composer model picker

[alexandersemenov27]

Contribution proposal

I prepared a local search field for the composer model picker in @deepseek-ai/dsh-client-ui-model-selection.

The search filters the displayed rows by model name, raw model id, or provider group. The complete directory remains authoritative for the active selection, opening or closing the picker resets the query, Escape clears a non-empty query, and an unmatched query shows the localized empty state. The change adds the matching English and Chinese locale keys and focused component coverage.

Review artifacts

• Review PR in the contributor fork: feat(client): local model search in the composer model picker alexandersemenov27/deepseek-harness#1
• Commit: alexandersemenov27@4eb574c
• Cross-fork comparison: master...alexandersemenov27:deepseek-harness:feat/model-select-search
• Browser demo: https://github.com/alexandersemenov27/deepseek-harness/blob/model-select-search-assets/model-search.gif?raw=true

Verification

• pnpm exec vitest run packages/client/ui-model-selection/tests/model-select.client.spec.tsx: 8 tests passed.
• The repository pre-push hook completed build:lib:host and typecheck:contracts-ready successfully.
• Agent Note format and translation-pairing checks passed.

GitHub currently reports that an owner has disabled opening pull requests in this repository. Would you prefer to enable Pull Requests for this contribution, cherry-pick 4eb574cde9, or use another contribution channel?

[liyangbing]

I reviewed the linked diff. The local filtering boundary and keeping choices authoritative are good, but the current keyboard behavior does not yet match the proposal.

ModelSelect attaches onRootKeyDown to the containing root. The search input handler calls only preventDefault() for a non-empty Escape; the event still bubbles. The root handler then sees Escape while pane === model and immediately changes the pane back to root. So one Escape currently clears the query and leaves the model pane, rather than only clearing the query.

The same bubbling affects ArrowUp/ArrowDown inside the search field: the parent prevents default and moves focus to a menu item, so those keys cannot behave as normal text-input cursor/navigation keys. This should be an explicit product choice and test, not an accidental consequence.

A safe fix is to make the root handler aware that the event originated from the search input and give that input first ownership of its text-editing keys, or stop propagation for the exact keys the input owns. Please also add focused tests for:

• non-empty Escape clears query and keeps the model pane/search focus;
• a second Escape backs out or closes according to the existing pane contract;
• ArrowUp/ArrowDown behavior while the searchbox owns focus;
• query reset after close and reopen;
• provider/group-name matching (claimed but not covered by the new tests);
• selected model/trigger identity remaining based on the unfiltered directory;
• unmatched query followed by clearing and successful selection.

One accessibility point is also worth checking with the project’s intended pattern: a textbox is now nested inside an element with role=menu. ARIA menu composites normally expose menuitem descendants and own arrow-key navigation; a free-text search control may fit a dialog/listbox/combobox structure better, or needs a tested focus/keyboard contract within the existing menu.

The implementation looks close, but the Escape regression should be resolved before cherry-picking because it contradicts both the proposal and Agent Note.

[alexandersemenov27]

Thanks — confirmed. I pushed follow-up commit 82fca0f575 to the review branch.

The update now:

• lets a non-empty Escape clear the query without leaving the model pane or losing focus;
• keeps ArrowUp/ArrowDown with the searchbox;
• moves focus on pane changes, then supports back → close → trigger-focus restoration;
• exposes the popup as a non-modal dialog, with menu roles only on non-empty actionable row lists;
• covers close/reopen reset, provider-name matching, unfiltered trigger identity, no-results recovery, empty panes, and the full keyboard/focus lifecycle.

Focused related tests pass: 26/26. The review PR is updated at alexandersemenov27#1.