Replies: 3 comments
|
Verified all three claims against Claim-by-claim confirmation:
The nuance (why the gate looks like it should already allow this): the Consequence for the fix: removing the schema default would not be the right move — it would flip every unconfigured model to "unknown", moving image failures downstream to the wire/API instead of failing the send with a clear code. Your toggle shape is exactly consistent with the fail-closed contract:
That keeps the default posture (a model that never declared image capability keeps rejecting) while giving users the single explicit way to opt a gateway model in. One suggestion for the copy: the gate already emits Scope note: since the editor is the "direct DeepSeek adapter's advisory model catalog" (its header comment), the same UI gap does not cover pi-ai custom providers — there the equivalent declaration is I did not see your fork diff, but the 7-file shape (editor + zh/en copy + tests) sounds right-sized. Happy to look at the diff if you drop a link here. |
|
Update / correction after reproducing the reporter's actual setup: The report covers TWO adapters, and only the first half was in the original post:
commit 5b0378c adds a Text (fixed) + Images checkbox pair to a declared pi-ai route's editor, writing Diff (both commits): Dxboy266/deepseek-harness@master...feat/model-image-input-toggle |
|
Thanks for the correction — it completes the picture, and I verified the pi-ai half against The route Verified resolution chain ( input: declaredInput(entry.input) ?? base?.input ?? [...request.defaultInput]
Fix shape checks out against the schema. Writing One connection worth making: CDeZT's #5366 (native dynamic model-catalog for CLIProxyAPI) is the dynamic remedy for the same pain — a fetched rich catalog (with |
Uh oh!
There was an error while loading. Please reload this page.
Problem
Custom OpenAI-compatible models that actually accept images (served through gateways) are rejected at send time with the generic toast "The current model does not support images". The model editor in Settings - Models offers no way to fix this, even though the server side already supports it.
Root cause
Everything needed is already in place - only the settings UI does not expose it:
packages/llm/llm-deepseek/src/index.ts- the catalog schema acceptsinputModalities, but defaults to["text"], so an unconfigured model is explicitly text-only.packages/api/session-controller/src/commands.ts- the send gate rejects an image wheninputModalitiesis defined without"image"(MODEL_DOES_NOT_SUPPORT_IMAGES).packages/client/ui-settings-models/src/client/DeepSeekModelsEditor.tsx- each row only writesid/name/contextWindow/maxTokens.So a user whose gateway model supports images has no in-product way to declare that, and every image send fails with copy that only says "switch models".
Suggested change
Expose an image input checkbox in each model row disclosure: checked writes
["text", "image"], unchecked removes the key (adapter default). Also point the rejection copy at that setting instead of only suggesting a model switch.I have this working on my fork (7 files, includes zh/en copy and test updates):
Diff: Dxboy266/deepseek-harness@master...feat/model-image-input-toggle
Happy to adjust naming/UX to whatever direction the team prefers - understood review capacity is limited, so posting here per CONTRIBUTING pointer to Discussions.
中文摘要
自定义 OpenAI 兼容模型实际支持图片,但 llm-deepseek 目录 schema 的 inputModalities 默认 ["text"],且 Web 设置的模型编辑器没有暴露该字段,导致发图固定被 MODEL_DOES_NOT_SUPPORT_IMAGES 拒绝。建议在模型行的展开区加图片输入开关(写入/删除 inputModalities),并把拒绝文案指向该设置。已在 fork 实现并附 diff。
All reactions