升级到 0.1.2 后，用 code 预设创建的会话无法 resume：preset "code" not found

[romans01]

Sessions created before 0.1.2 under the shipped code preset fail to resume after the rename to ptc.

复现、预期与验收 / Repro, expected, acceptance

• 复现步骤 / Steps
  1. On dsh 0.1.1-rc.2 (or earlier), create a Web session with the shipped code preset (the default at the time). Optionally set agent-presets.default: code in settings.yaml.
  2. Upgrade to dsh 0.1.2-rc.1 (also reproduced on 0.1.3-alpha.1 / current master).
  3. Open that session in the Web UI, or start a new session without an explicit preset while default: code is still stored.
• 实际结果 / Actual

  resume failed for session "session-…": RemoteError: agent-presets:
  preset "code" not found (available: standard, ptc, minimal, cordis) (gateway/internal)
  

  Every pre-0.1.2 session created under code is affected; so is any deployment whose settings still name code as the default.
• 预期结果 / Expected
  A session logged under the old preset id resumes on the renamed shipped preset, as the release note promised ("Rename Code Mode to PTC mode while keeping existing conversation records readable").
• 环境 / Environment
  @deepseek-ai/dsh 0.1.2-rc.1 (community container runzhliu/deepseek-harness:0.1.2-rc.1-r1), Node 24, Linux. Code path is unchanged on master @ d347e70.
• 验收条件 / Acceptance
  agentPresets.resolve('code') and resolve() with default: code return the ptc preset when a root supplies ptc; a root that still supplies code wins; unknown ids still raise agent-preset/not-found; the roster never lists code.

原因 / Root cause

Commit 3ca9c7d "rename code-mode to ptc (PTC mode), except session-persistent vocabulary" renamed presets/code → presets/ptc. The session-persistent vocabulary it deliberately kept covers tool/code-dispatch* events, the logged plugin name and the sub-call id segment — but not the agentPreset value in the session header (and in agent-preset/selected events). AgentPresets.resolve() (packages/preset/agent-presets/src/index.ts) looks an id up across the configured roots and throws when none supplies it; there is no alias for a retired id. The session-format-v0-to-v1 / v1-to-v2 codecs copy agentPreset verbatim, so a format migration does not repair it either.

修复建议 / Proposed fix

A small map from retired ids to successors, consulted in resolve() after the roots (so a root that still ships the old id keeps winning), with tests. Verified locally on master: vitest run packages/preset/agent-presets 192/192, tsc -b clean, oxlint clean, per-file coverage of packages/preset/agent-presets/src stays 100%.

Patch (also usable with git am): see attachment / below.

diff --git a/packages/preset/agent-presets/src/index.ts b/packages/preset/agent-presets/src/index.ts
index e3576868e..51c877149 100644
--- a/packages/preset/agent-presets/src/index.ts
+++ b/packages/preset/agent-presets/src/index.ts
@@ -54,6 +54,22 @@ export type {
 /** Settings namespace carrying the user's chosen default preset. */
 export const SETTINGS_NAMESPACE = 'agent-presets'
 
+/**
+ * Preset ids retired by a rename, keyed to the id that replaced each one.
+ *
+ * A released Session log records the creation-time preset id in its header
+ * and in `agent-preset/selected` events, and the adjacent-migration contract
+ * carries that vocabulary forward verbatim. A session created before a rename
+ * therefore still asks for the old id on resume; without this map every such
+ * session fails with `agent-preset/not-found` although its composition still
+ * ships under the new name. The roster never lists a retired id — it only
+ * answers a lookup for one with its successor.
+ */
+export const LEGACY_PRESET_IDS: Readonly<Record<string, string>> = {
+  // 2026-08-25: "rename code-mode to ptc (PTC mode)" renamed the shipped preset.
+  code: 'ptc',
+}
+
 /** Refuse an empty preset id before invoking a domain operation. */
 function validatePresetId(value: string, field: 'agentPreset' | 'from'): void {
   if (value.length === 0) {
@@ -344,15 +360,23 @@ export class AgentPresets extends TypertRemoteService {
     const wanted = id ?? this.defaultId
     const presets = await this.list()
     const found = presets.find(preset => preset.id === wanted)
-    if (found === undefined) {
-      const available = presets.map(preset => preset.id)
-      throw new RemoteError(
-        'agent-preset/not-found',
-        `agent-presets: preset "${wanted}" not found (available: ${available.join(', ') || 'none'})`,
-        { agentPreset: wanted, available },
-      )
-    }
-    return found
+    if (found !== undefined) return found
+
+    // A retired id resolves to its successor, so sessions logged before a
+    // rename keep resuming. Only a configured root may still supply the old id
+    // (first-root-wins above), so the successor is consulted after the roots.
+    const successor = LEGACY_PRESET_IDS[wanted]
+    const renamed = successor === undefined
+      ? undefined
+      : presets.find(preset => preset.id === successor)
+    if (renamed !== undefined) return renamed
+
+    const available = presets.map(preset => preset.id)
+    throw new RemoteError(
+      'agent-preset/not-found',
+      `agent-presets: preset "${wanted}" not found (available: ${available.join(', ') || 'none'})`,
+      { agentPreset: wanted, available },
+    )
   }
 
   /**
diff --git a/packages/preset/agent-presets/tests/legacy-preset-id.spec.ts b/packages/preset/agent-presets/tests/legacy-preset-id.spec.ts
new file mode 100644
index 000000000..3c79b8f02
--- /dev/null
+++ b/packages/preset/agent-presets/tests/legacy-preset-id.spec.ts
@@ -0,0 +1,120 @@
+/**
+ * Retired preset ids keep resolving. A released Session log carries the
+ * creation-time `agentPreset` verbatim across format migrations, so a session
+ * created under a since-renamed shipped preset asks the roster for the old id
+ * on resume. The roster answers with the successor instead of
+ * `agent-preset/not-found`, both for an explicit id and for a stored default.
+ */
+
+import { mkdir, mkdtemp, writeFile } from 'node:fs/promises'
+import { tmpdir } from 'node:os'
+import { dirname, join } from 'node:path'
+import { fileURLToPath, pathToFileURL } from 'node:url'
+import { Context } from '@deepseek-ai/cordis'
+import Loader from '@deepseek-ai/cordis-plugin-loader'
+import Include from '@deepseek-ai/cordis-plugin-include'
+import LlmRuntime from '@deepseek-ai/dsh-llm'
+import SessionStore from '@deepseek-ai/dsh-session'
+import SessionProjectionRegistry from '@deepseek-ai/dsh-session-projection'
+import SystemPrompt from '@deepseek-ai/dsh-system-prompt'
+import ToolRuntime from '@deepseek-ai/dsh-tools'
+import AgentRegistry from '@deepseek-ai/dsh-agent'
+import AgentLoop from '@deepseek-ai/dsh-agent-loop'
+import FileSettingsProvider from '@deepseek-ai/dsh-settings-file'
+import { describe, expect, it } from 'vitest'
+import AgentPresets, { COMPOSITION_FILE, LEGACY_PRESET_IDS, SETTINGS_NAMESPACE } from '@deepseek-ai/dsh-agent-presets'
+
+const FIXTURES = join(dirname(fileURLToPath(import.meta.url)), 'fixtures')
+const ROOTS = [{ path: join(FIXTURES, 'system'), trust: 'system' as const }]
+const NS = SETTINGS_NAMESPACE
+
+/** The one retired id this suite exercises, and the successor the map must name. */
+const RETIRED = 'code'
+const SUCCESSOR = 'ptc'
+
+/** A user root supplying only `id`, composed from the contribute fixture. */
+async function rootWith(id: string): Promise<string> {
+  const root = await mkdtemp(join(tmpdir(), 'dsh-preset-legacy-'))
+  await mkdir(join(root, id))
+  await writeFile(
+    join(root, id, COMPOSITION_FILE),
+    `- id: only\n  name: ${join(FIXTURES, 'plugins', 'contribute.js')}\n  config:\n    tool: only\n`,
+  )
+  return root
+}
+
+/** The same composition `settings.spec.ts` builds, with a file-backed settings provider. */
+async function harness(
+  extraRoots: readonly { path: string; trust: 'system' | 'user' }[] = [],
+): Promise<Context> {
+  const home = await mkdtemp(join(tmpdir(), 'dsh-preset-legacy-settings-'))
+  const settingsFile = join(home, 'settings.yaml')
+  await writeFile(settingsFile, '{}\n')
+
+  const ctx = new Context()
+  ctx.baseUrl = pathToFileURL(FIXTURES).href + '/'
+  await ctx.plugin(Loader)
+  ctx.loader.builtins.include = Include
+  await ctx.plugin(LlmRuntime)
+  await ctx.plugin(SessionStore)
+  await ctx.plugin(SessionProjectionRegistry)
+  await ctx.plugin(SystemPrompt, { persona: '' })
+  await ctx.plugin(ToolRuntime)
+  await ctx.plugin(AgentRegistry)
+  await ctx.plugin(AgentLoop, { agents: [] })
+  await ctx.plugin(FileSettingsProvider, { path: settingsFile, watch: false })
+  await ctx.plugin(AgentPresets, {
+    default: 'standard',
+    roots: [...ROOTS, ...extraRoots],
+    includeShippedRoot: false,
+    includeUserRoot: false,
+  })
+  return ctx
+}
+
+describe('retired preset ids', () => {
+  it('names the successor of the shipped rename', () => {
+    expect(LEGACY_PRESET_IDS).toStrictEqual({ [RETIRED]: SUCCESSOR })
+  })
+
+  it('resolves a retired id to its successor when a root supplies the successor', async () => {
+    const ctx = await harness([{ path: await rootWith(SUCCESSOR), trust: 'user' }])
+
+    const resolved = await ctx.agentPresets.resolve(RETIRED)
+
+    expect(resolved.id).toBe(SUCCESSOR)
+  })
+
+  it('resolves a stored default naming the retired id the same way', async () => {
+    const ctx = await harness([{ path: await rootWith(SUCCESSOR), trust: 'user' }])
+    await ctx.settings.update(NS, { default: RETIRED })
+
+    expect(ctx.agentPresets.defaultId).toBe(RETIRED)
+    expect((await ctx.agentPresets.resolve()).id).toBe(SUCCESSOR)
+  })
+
+  it('lets a root that still supplies the retired id win over the successor', async () => {
+    const ctx = await harness([
+      { path: await rootWith(RETIRED), trust: 'user' },
+      { path: await rootWith(SUCCESSOR), trust: 'user' },
+    ])
+
+    expect((await ctx.agentPresets.resolve(RETIRED)).id).toBe(RETIRED)
+  })
+
+  it('still reports the retired id as not found when no root supplies the successor', async () => {
+    const ctx = await harness()
+
+    await expect(ctx.agentPresets.resolve(RETIRED))
+      .rejects.toThrow(/preset "code" not found \(available: minimal, standard\)/)
+  })
+
+  it('never lists the retired id in the roster', async () => {
+    const ctx = await harness([{ path: await rootWith(SUCCESSOR), trust: 'user' }])
+
+    const ids = (await ctx.agentPresets.list()).map(preset => preset.id)
+
+    expect(ids).toContain(SUCCESSOR)
+    expect(ids).not.toContain(RETIRED)
+  })
+})
-- 
2.53.0

用户侧临时方案 / Workaround for users

Without changing the code: put an alias into the user preset root $DSH_HOME/.agent-presets/code/ — a byte-for-byte copy of the shipped presets/ptc/agent.cordis.yml plus a preset.yml (name: code (legacy → PTC)) — and set agent-presets.default: ptc in settings.yaml. Discovery re-reads roots on every call, so no restart is needed for the alias. Keep the copy in sync with ptc on each upgrade.

[Mide69]

Independently verified the two load-bearing facts against current master, both hold up exactly.

Commit 3ca9c7d "rename code-mode to ptc (PTC mode), except session-persistent vocabulary" is real and in the history.

The current resolve() in packages/preset/agent-presets/src/index.ts matches your diff's context lines exactly, line for line: const wanted = id ?? this.defaultId, const presets = await this.list(), const found = presets.find(preset => preset.id === wanted), and the same RemoteError throw shape. Your patch would apply cleanly against master as it stands right now. I also grepped for LEGACY_PRESET_IDS across the whole tree and got zero hits, so this hasn't been fixed yet.

Nice catch that the migration codecs copy agentPreset verbatim rather than translating it, that's the part that makes this a genuine gap rather than something format migration already covers. The successor-lookup-after-roots ordering in your patch also correctly preserves the case where a user root still ships an alias under the old name, which is a detail that would have been easy to get backwards.

This looks ready to go as-is. Given CONTRIBUTING.md doesn't take external PRs, hopefully a maintainer picks this up directly, since you've already done the verification work for them.

[lybym]

I reproduced a related variant on Windows with @deepseek-ai/dsh 0.1.2-rc.1.

The affected workspace contained a persisted blank session (0 turns) whose projection metadata had sessionListMetadata.blank: true but no agentPreset row. Another workspace's blank session had agentPreset: "standard" and worked normally.

When selecting/creating the blank session in the affected workspace, the sidebar selected New session while the main panel rendered an older session (including its historical code preset). Switching the model to DeepSeek-V4-Pro then failed with:

gateway/internal: resume failed for session "…": RemoteError: agent-presets: preset "code" not found (available: standard, ptc, minimal, cordis)

So in addition to aliasing code -> ptc, it seems worth handling legacy/incomplete blank-session projection records defensively: initialize missing agentPreset to the configured default, and ensure the sidebar selection, session panel, and model operation resolve the same session id.

As a local workaround, after backing up storage, removing the empty malformed session record from the affected workspace index caused Harness to create a fresh blank session with standard; the session panel and V4-Pro model selection then worked correctly.