[Bug] Desktop packaging fails at prepare:dsh: runtime-payload-smoke.mjs still requires removed fs-ext

[tiexo]

Summary

pnpm run package:desktop:win:x64:unsigned fails deterministically at the prepare:dsh step:

Error: desktop native payload smoke failed: Cannot find module 'fs-ext'
Require stack:
- apps/desktop/.desktop-build/targets/win-x64/dsh/package.json
    at checkFsExt (apps/desktop/tests/fixtures/runtime-payload-smoke.mjs:69:17)

Root cause

apps/desktop/tests/fixtures/runtime-payload-smoke.mjs still verifies a dependency that no longer exists in the tree.

Commit d927cbff9 ("feat(native): add prebuilt Node-API flock support", 2026-09-07) replaced fs-ext with @deepseek-ai/node-addon-system in packages/session/session-persistence-jsonl/package.json:

-    "fs-ext": "2.1.1",
+    "@deepseek-ai/node-addon-system": "workspace:^",
-    "@types/fs-ext": "2.0.3"

The smoke fixture was not updated. Evidence that fs-ext is intentionally gone:

• No tracked package.json in the repository declares it, and pnpm-lock.yaml has no fs-ext entry.
• No source file requires it — the only seekSync / fsExt occurrences anywhere in the tree are inside the fixture itself.
• selectDesktopPackageClosure() in apps/desktop/scripts/prepare-package-set.ts walks dependencies / peerDependencies / optionalDependencies, so the package set and the packed dsh runtime correctly contain no fs-ext.

The fixture's last change is fc7abdcfb ("feat: 优化 windows 安装包打包", 2026-09-09) — two days after the removal.

runtime-file-policy.ts and project-manager.ts also still mention fs-ext, but both are harmless: the former is a pure string filter unit-tested on synthetic paths, and the latter's allowBuilds: fs-ext: true targets user-installed external plugins in the desktop profile, not the core runtime payload.

Reproduction

git clone https://github.com/deepseek-ai/deepseek-harness.git
cd deepseek-harness
pnpm install
$env:DSH_DESKTOP_APP_ID = 'com.deepseek.harness.desktop'
pnpm run package:desktop:win:x64:unsigned

Fails deterministically at prepare:dsh → runtime payload smoke.

Suggested fix

Drop checkFsExt() from apps/desktop/tests/fixtures/runtime-payload-smoke.mjs — the function, its call in the try block, the fsExt: true field in the summary log, and the now-unused closeSync / openSync / readSync imports. No coverage is lost: the shipped native capabilities remain exercised by checkKoffi (FFI), checkSharp, checkHtml and checkPty.

Verified end-to-end locally on Windows 11 x64, Node v24.18.0, pnpm 11.7.0, commit c291e79 (0.1.5-rc.2): with that check removed, packaging completes and produces a working deepseek-harness-0.1.5-rc.2-win-x64.exe (171.7 MB) that installs and launches.

Side note on build prerequisites

No Visual Studio / MSVC is actually required for the unsigned Windows target. node-pty's install script is node scripts/prebuild.js || node-gyp rebuild and resolves from prebuilds/win32-x64/; koffi and node-addon-require-builtin ship prebuilt binaries as well. The README's "Visual C++ build tools" requirement only applies to the node-gyp fallback path. Might be worth softening that wording, since it reads as a hard prerequisite for local Windows packaging.

[PerryLink]

已对照 master（c291e7961a）逐行复核，问题属实，机制如下：

• apps/desktop/scripts/prepare-dsh.ts:142 在 prepare:dsh 阶段用打包内置 Node 执行 tests/fixtures/runtime-payload-smoke.mjs；
• smoke 的 checkFsExt()（runtime-payload-smoke.mjs:67-83）通过 requireRuntime('fs-ext') 加载 fs-ext 并做 seek 断言；
• 当前依赖树里已没有任何包依赖 fs-ext（pnpm-lock.yaml 只剩 fs-extra），所以发布物中没有该模块 → Cannot find module 'fs-ext' 必现。
• 但仓库还有多处 fs-ext 残留：apps/desktop/scripts/runtime-file-policy.ts:26-30（构建产物排除规则）、apps/desktop/src/project-manager.ts:109（allowBuilds 白名单）——说明"依赖被移除后 smoke 与策略表没有同步清理"。native/system 的 flock 现在由仓库自带 system.node 实现（见 native/system/docs/architecture.md），fs-ext 确无运行时消费者。

修复方向（任一）：
① 把 fs-ext 加回 apps/desktop 的 devDependencies（smoke 只在打包期跑，构建期依赖足够）；② 若 fs-ext 确已废弃，删除/改造 checkFsExt 断言并同步清理 policy 残留。

临时规避：打包机在 apps/desktop 下 pnpm add -D fs-ext 后重试即可通过。

诚实标注：fs-ext 是在哪次提交被移除的，我没有在本快照里做历史考古；以上结论基于当前树的静态事实。另外 #6612 是同一问题的独立复报，两帖可合并跟进。