Replies: 1 comment
|
The patch for this report is available on a fork, because pull requests are disabled for this repository:
Contents:
Evidence: |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Summary
In the packaged Desktop application on macOS, the standard editing shortcuts do nothing: ⌘V, ⌘C, X and ⌘A are inert in every text field, including the composer. There is no right-click context menu either, so text cannot be pasted by any route.
Environment
Steps to reproduce
Observed: nothing is inserted; ⌘C, ⌘X and ⌘A behave the same way. Typing works normally.
Cause
apps/desktop/src/main.tsinstalls a custom application menu whose only top-level menu is the application menu:macOS delivers the standard editing shortcuts through menu roles. Without an Edit menu, the paste/copy/cut/select-all commands never reach the renderer, and the Desktop adds no
webContentscontext-menu handler as a fallback. Repository evidence:rg "role: '(copy|paste|cut|selectAll|undo|redo)'"over the repository returns nothing.context-menuhandler underapps/desktop/src.git log -S editMenu -- apps/desktop/src/main.tsis empty, so the packaged Desktop has never offered an Edit menu.The composer itself is fine: its Lexical
PASTE_COMMANDhandler (packages/client/ui-conversation/src/client/input/editor/keymap.ts) already routes pasted text, images and files. It simply never receives the gesture.This is macOS-specific: on Windows and Linux the renderer handles Ctrl+V natively, so the same source shows no symptom there.
Suggested fix
Add the standard editing menu where the platform requires it:
Role-based entries keep the labels system-localized, so no UI copy needs to be added to the locale dictionaries. A regression assertion can check that the macOS template contains the
editMenurole (for example inapps/desktop/tests/main-startup.spec.ts).All reactions