pnpm run clean fails out of the box on 0.1.7-rc.2: clean.ts rejects the desktop-keyboard-tests tsconfig outDir

[HaipingShi]

pnpm run clean fails out of the box on 0.1.7-rc.2

TL;DR

On a clean checkout of current master (dsh-v0.1.7-rc.2), pnpm run clean exits 1 before deleting anything:

$ pnpm run clean

clean: expected TypeScript outDir to end in /types: lib/desktop-keyboard-test-types
[ELIFECYCLE] Command failed with exit code 1.

The new tsconfig.desktop-keyboard-tests.json declares "outDir": "lib/desktop-keyboard-test-types", and scripts/clean.ts only accepts outDirs whose basename is types (plus one special-cased native entry), so plan-time validation throws and the tool never reaches deletion.

Why it matters

This is the recovery command that several threads prescribe for the class of failure where a version switch over a long-lived checkout leaves stale lib/ output that breaks the typert/tool layer — #7086 documents exactly that symptom and the standard pnpm run clean → pnpm install → pnpm run build procedure. With clean itself broken, that procedure is currently not executable; the only workaround is removing lib/ directories and *.tsbuildinfo files by hand.

Root cause

• tsconfig.desktop-keyboard-tests.json was added in 6a82709a2b ("fix(shortcuts): preserve focus and tab layout, block overlay input", 09-22) with outDir: lib/desktop-keyboard-test-types.
• Root tsconfig.json → tsconfig.client.json (reference at its line 46) → tsconfig.desktop-keyboard-tests.json, so the file is reachable from the graph RepositoryCleaner.buildOutputDirectories() walks.
• That walk validates every reached outDir: basename(...) === 'types' or the native/system/packages/entry/lib exception; desktop-keyboard-test-types matches neither, so it throws before any target is collected.

Verified against current upstream master: scripts/clean.ts and the tsconfig are byte-identical in my tree, so this is not a fork artifact.

Suggested fixes

Either of:

1. Nest the outDir so it ends in /types (e.g. lib/desktop-keyboard-tests/types), keeping the clean.ts rule as-is; or
2. Extend buildOutputDirectories() with this outDir as an explicit exception, the way nativeEntryOutput already is.

Happy to send the one-liner for either direction if maintainers say which they prefer.