Replies: 1 comment
|
Confirmed on rc.7: the fetch client still calls |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Bug:
crypto.randomUUID is not a functionwhen accessing the Web GUI over plain HTTP on another deviceEnvironment:
@deepseek-ai/dsh0.1.0-rc.6, accessed from a phone on the same LAN athttp://<lan-ip>:<port>(plain HTTP, non-localhost).Symptom: The page loads but shows no conversation/model data, with
crypto.randomUUID is not a functionin the console.Root cause:
crypto.randomUUIDis only exposed in a secure context (HTTPS orlocalhost). On a plain-HTTP LAN origin the API is absent. The production RPC client mints its request ids here:packages/host/apiproxy/src/fetch/client.ts→mintRpcId()→RpcId(crypto.randomUUID())Note: the browser-safe replacement already exists in the repo —
packages/client/connection/src/client/random-uuid.ts→randomUuid(), which usescrypto.getRandomValues()(available on insecure origins) and is already used by the connection client's other paths (rpc.ts,fixture.ts). It just isn't wired intomintRpcId().Suggested fix: use
randomUuid()inmintRpcId()(and, for consistency, the browser draft-attachment id in the conversation UI) instead ofcrypto.randomUUID().Happy to submit a PR if it helps — this blocks LAN/mobile access to the Web GUI.
All reactions