feat: Add run_async methods to SearchApiWebSearch and SerperDevWebSearch
#10484
+326
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxdswain is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
bot
added
topic:tests
type:documentation
maxdswain
changed the title
run_async methods to SearchApiWebSearch and SerperDevWebSearchrun_async methods to SearchApiWebSearch and SerperDevWebSearch
Collaborator
Pull Request Test Coverage Report for Build 21547228321Details
💛 - Coveralls |
Contributor
|
@maxdswain thanks for the changes! Could you also add a release note following our instructions here: https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes |
sjrl
approved these changes
Feb 2, 2026
Contributor
sjrl
left a comment
sjrl
left a comment
There was a problem hiding this comment.
Looks good @maxdswain! Just need the release note and we can merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
run_asyncfor all Websearch Pipeline components #10445Proposed Changes:
run_asyncmethods toSearchApiWebSearchandSerperDevWebSearchrunandrun_asyncmethods (requests doesn't support async)How did you test it?
New units and integration tests mirroring the existing unit/integration tests for the respective
runmethods.Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.