Skip to content

fix: Fix the type name used in tracing for the tags haystack.component.input_spec and output_spec#10626

Merged
sjrl merged 4 commits intomainfrom
fix-input-spec-tracing
Feb 19, 2026
Merged

fix: Fix the type name used in tracing for the tags haystack.component.input_spec and output_spec#10626
sjrl merged 4 commits intomainfrom
fix-input-spec-tracing

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Feb 19, 2026

Related Issues

Proposed Changes:

Update how we create the type name which is now robust across python versions

How did you test it?

Updated existing tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl sjrl requested a review from a team as a code owner February 19, 2026 08:27
@sjrl sjrl requested review from bogdankostic and removed request for a team February 19, 2026 08:27
@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Feb 19, 2026 8:45am

Request Review

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works great...

Feel free to merge once you have silenced the linting error

@sjrl sjrl enabled auto-merge (squash) February 19, 2026 08:47
@sjrl sjrl merged commit 2554d02 into main Feb 19, 2026
21 checks passed
@sjrl sjrl deleted the fix-input-spec-tracing branch February 19, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments