Skip to content

fix: DeleteAllAsyncTest, DeleteByFilterAsyncTest,#10952

Merged
davidsbatista merged 4 commits intodeepset-ai:mainfrom
pandego:fix/10919-deleteallasynctest-deletebyfilterasynctest
Mar 27, 2026
Merged

fix: DeleteAllAsyncTest, DeleteByFilterAsyncTest,#10952
davidsbatista merged 4 commits intodeepset-ai:mainfrom
pandego:fix/10919-deleteallasynctest-deletebyfilterasynctest

Conversation

@pandego
Copy link
Copy Markdown
Contributor

@pandego pandego commented Mar 27, 2026

Summary

Validation

  • Local validation attempted in execute worker

@pandego pandego requested a review from a team as a code owner March 27, 2026 11:15
@pandego pandego requested review from anakin87 and removed request for a team March 27, 2026 11:15
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

@pandego is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 27, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type:documentation Improvements on the docs label Mar 27, 2026
anakin87
anakin87 previously requested changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please stop opening many PRs targeting this repo. Focus on one at a time instead.
  2. Sign the CLA, otherwise PRs will be ignored.

@anakin87 anakin87 mentioned this pull request Mar 27, 2026
Merged
@pandego
Copy link
Copy Markdown
Contributor Author

pandego commented Mar 27, 2026

  1. Please stop opening many PRs targeting this repo. Focus on one at a time instead.

  2. Sign the CLA, otherwise PRs will be ignored.

Duly noted @anakin87, I’ll keep it to one PR at a time, CLA signed btw.

@anakin87
Copy link
Copy Markdown
Member

anakin87 commented Mar 27, 2026

Thank you!

@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 27, 2026
@anakin87 anakin87 requested a review from davidsbatista March 27, 2026 15:11
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Mar 27, 2026 3:14pm

Request Review

davidsbatista
davidsbatista approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some needed adjustments and a missing operation in InMemoryDocumentStore

@anakin87 anakin87 self-requested a review March 27, 2026 15:19
@anakin87 anakin87 dismissed their stale review March 27, 2026 15:19

already reviewed by David

@davidsbatista davidsbatista merged commit d7c51f6 into deepset-ai:main Mar 27, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@anakin87 anakin87 Awaiting requested review from anakin87

Assignees

No one assigned

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeleteAllAsyncTest, DeleteByFilterAsyncTest,

4 participants

@pandego @CLAassistant @anakin87 @davidsbatista