Skip to content

test: use historical API for Open Meteo API in TestOpenAPIConnectorIntegration#11046

Merged
anakin87 merged 3 commits intomainfrom
replace-open-meteo
Apr 7, 2026
Merged

test: use historical API for Open Meteo API in TestOpenAPIConnectorIntegration#11046
anakin87 merged 3 commits intomainfrom
replace-open-meteo

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 7, 2026

Related Issues

Proposed Changes:

How did you test it?

CI

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Apr 7, 2026 8:46am

Request Review

@anakin87 anakin87 marked this pull request as ready for review April 7, 2026 08:29
@anakin87 anakin87 requested a review from a team as a code owner April 7, 2026 08:29
@anakin87 anakin87 requested review from bogdankostic and removed request for a team April 7, 2026 08:29
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 7, 2026 •
edited
Loading

Coverage Report for CI Build 24072687951

Coverage remained the same at 92.86%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 17143
Covered Lines: 15919
Line Coverage: 92.86%
Coverage Strength: 0.93 hits per line
💛 - Coveralls

@anakin87 anakin87 self-assigned this Apr 7, 2026
bogdankostic
bogdankostic approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just remove the print statement before merging.

test/components/connectors/test_openapi_connector.py Outdated
)
assert isinstance(response, dict)
assert "response" in response
print(response)
Copy link
Copy Markdown
Contributor

@bogdankostic bogdankostic Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this print statement before merging.

Copy link
Copy Markdown
Member Author

@anakin87 anakin87 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you

@anakin87 anakin87 enabled auto-merge (squash) April 7, 2026 08:46
@anakin87 anakin87 merged commit 940e9c7 into main Apr 7, 2026
20 checks passed
@anakin87 anakin87 deleted the replace-open-meteo branch April 7, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdankostic bogdankostic bogdankostic approved these changes

Assignees

@anakin87 anakin87

Labels

topic:tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anakin87 @coveralls @bogdankostic