Skip to content

refactor!: Remove agent breakpoint and agent snapshot#11202

Draft
sjrl wants to merge 4 commits intomainfrom
refactor-agent-tool-invoker
Draft

refactor!: Remove agent breakpoint and agent snapshot#11202
sjrl wants to merge 4 commits intomainfrom
refactor-agent-tool-invoker

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented Apr 27, 2026

Related Issues

  • WIP and just experimenting

Proposed Changes:

Remove break point and snapshot support from the internals of Agent. Motivation is that it's not heavily used and adds a lot of complexity to the Agent internals.

Open to adding this back in the future if we see a strong need (e.g. HITL + Breakpoints to enable long running Agents). And if we decide to do so I think there is a simpler way to re-add it than in it's current form.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Apr 28, 2026 10:18am

Request Review

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Apr 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/agents
  agent.py 842, 848-864
  haystack/components/tools
  tool_invoker.py
  haystack/core
  errors.py 127, 142-144, 151-153
  haystack/core/pipeline
  async_pipeline.py
  base.py
  breakpoint.py 53, 94-97, 188
  pipeline.py 340, 356-357
  haystack/dataclasses
  __init__.py
  breakpoints.py
  haystack/human_in_the_loop
  strategies.py 471
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant