feat: support reference ranges in AnswerBuilder (e.g. [1-3])#11214
Open
GauravPatil2515 wants to merge 1 commit intodeepset-ai:mainfrom
Open
feat: support reference ranges in AnswerBuilder (e.g. [1-3])#11214GauravPatil2515 wants to merge 1 commit intodeepset-ai:mainfrom
GauravPatil2515 wants to merge 1 commit intodeepset-ai:mainfrom
Conversation
Closes deepset-ai#11002 AnswerBuilder now expands range references like [1-3] into individual document references [1], [2], [3] when extracting referenced documents. Invalid ranges like [3-1] are ignored.
|
@GauravPatil2515 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
Bot
added
topic:tests
type:documentation
Contributor
|
@GauravPatil2515 thanks for the contribution! Could we make this opt in behavior? So add a init param that toggles whether this used or not and turn it off by default so we keep the expected default behavior. |
sjrl
reviewed
Apr 29, 2026
|
|
||
| def test_run_with_range_reference_pattern(self): | ||
| builder = AnswerBuilder(reference_pattern=r"\[(\d+)\]") | ||
| replies = ["Paris [1-2] and Rome [3]."] |
Contributor
There was a problem hiding this comment.
Let's also add a test with a more complicated reference like [2-5, 7, 10, 14-16] to see if it works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11002
AnswerBuilder now expands range references like [1-3] into individual document references [1], [2], [3] when extracting referenced documents. Invalid ranges like [3-1] are ignored.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.