Skip to content

fix: Add missing init param to to_dict in hf doc embedder#11320

Merged
sjrl merged 2 commits into
mainfrom
fix-sede-hf-doc-embedder
May 18, 2026
Merged

fix: Add missing init param to to_dict in hf doc embedder#11320
sjrl merged 2 commits into
mainfrom
fix-sede-hf-doc-embedder

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented May 15, 2026

Related Issues

  • fixes #issue-number

Proposed Changes:

Fixed HuggingFaceAPIDocumentEmbedder serialization to preserve the configured concurrency_limit.

How did you test it?

Updated tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl sjrl requested a review from a team as a code owner May 15, 2026 08:20
@sjrl sjrl requested review from julian-risch and removed request for a team May 15, 2026 08:20
@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment May 18, 2026 8:40am

Request Review

@sjrl sjrl self-assigned this May 15, 2026
@sjrl sjrl enabled auto-merge (squash) May 15, 2026 08:20
@claude
Copy link
Copy Markdown

claude Bot commented May 15, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/embedders
  hugging_face_api_document_embedder.py
Project Total  

This report was generated by python-coverage-comment-action

@sjrl
Copy link
Copy Markdown
Contributor Author

sjrl commented May 15, 2026

Errors are unrelated to changes I made. Looks like an issue on HuggingFace's end.

@sjrl
Copy link
Copy Markdown
Contributor Author

sjrl commented May 18, 2026

@julian-risch could you review this when you have the chance?

@sjrl sjrl merged commit 4c89081 into main May 18, 2026
25 checks passed
@sjrl sjrl deleted the fix-sede-hf-doc-embedder branch May 18, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants