build: add lightweight npm supply chain guardrails#11360
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1336505 to
8cb34ce
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
@julian-risch I think this looks good. Did you have a chance to test to see if this build works or will we see next time the docs website is rebuilt? |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Member
Author
I reproduced the workflow steps locally, particularly the |
sjrl
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Changes
check_api_ref.yml— pinnpx docusaurus-mdx-checkerto@3.0.0:npxfetched the latest version on every run with no version pin, so a compromised release could land in CI immediately. Now pinned to the current latest (3.0.0). Updates can be applied deliberately when needed.docs_search_sync.yml— add--ignore-scriptstonpm install, then explicitly rebuildsharp:npm install --ignore-scriptsblockspreinstall/install/postinstalllifecycle hooks across all packages which is a common supply chain attack vectors. Risk here is that there are any hooks that are required and this change will make them fail. We'll see.npm rebuild sharpthen re-runs only sharp's install script. Sharp is a native module (libvips bindings) that downloads a platform-specific prebuilt binary in its install script — without it,@docusaurus/plugin-ideal-imageand other Docusaurus image code would fail at build time..github/dependabot.yml— add npm ecosystem entry:npmentry for/docs-websiteon a daily cadence withcooldown.default-days: 1, matching what we use for GitHub actions and pip. Dependabot will open bump PRs for direct dependencies inpackage.json.Notes for the reviewer
I chose to not commit
docs-website/package-lock.jsonor switch tonpm ci. The lockfile is ~900KB and would generate frequent Dependabot bumps touching it because that would include all transitive dependencies. Not just direct dependencies.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.🤖 Generated with Claude Code