bug: handle Optional params in schema validation#2980
Merged
ZanSara merged 22 commits intodeepset-ai:mainfrom Aug 24, 2022
anakin87:handle_optional_params
Merged
bug: handle Optional params in schema validation#2980ZanSara merged 22 commits intodeepset-ai:mainfrom anakin87:handle_optional_params
Optional params in schema validation#2980ZanSara merged 22 commits intodeepset-ai:mainfrom
anakin87:handle_optional_params
Conversation
Member
Author
Notes for the reviewerIn
The test tries to load a pipeline, with a |
…dle_optional_params
…dle_optional_params
Member
This reverts commit 0114cba1f72c9bab23a3ce6a24cb4b346834cf34.
ZanSara
approved these changes
Aug 24, 2022
Contributor
ZanSara
left a comment
There was a problem hiding this comment.
Amazing, thank you! The test is 100% exactly as I had it in mind 😊
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Optionaltyped params #2589Proposed Changes:
First draft to manually temporarily fix this problem.
When Pydantic v2 will be released, there will be no need of this fix.
How did you test it?
Included test
Notes for the reviewer
Checklist