refactor: rename master into main in documentation and links#3063
Merged
refactor: rename master into main in documentation and links#3063
master into main in documentation and links#3063Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
julian-risch
requested changes
Aug 22, 2022
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
Looks quite good to me already. I found a few sphinx-doc.org links where master must not be renamed to main. Further, there is still once occurrence of master in test/samples/dc/pipeline_config.json. We should rename that too, right?
…tack into rename-master-in-schemas
julian-risch
approved these changes
Aug 23, 2022
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
The change requests are addressed now. 👍 As soon as all tests pass, this PR is ready to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
masteracross the whole codebase #3051Proposed Changes:
Mass refactoring of
masterintomain, taking care of not renaming it when the link/documentation references another project.Notes for the reviewer
There should be no other changes than renames from
mastertomain. If any other change is spotted please flag it.Checklist
I added tests that demonstrate the correct behavior of the changeI documented my code