fix: Crawler quits ChromeDriver on destruction#3070
Merged
ZanSara merged 2 commits intodeepset-ai:mainfrom Aug 22, 2022
Merged
Conversation
danielbichuetti
changed the title
danielbichuetti
changed the title
ZanSara
approved these changes
Aug 22, 2022
Contributor
ZanSara
left a comment
ZanSara
left a comment
There was a problem hiding this comment.
Ah good catch! Thank you 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Today, Crawler will instantiate ChromeDriver, use it, and it will never close the window or the ChromeDriver itself.
This change will close the browser window and quit the ChromeDriver instance during object destruction.
How did you test it?
Tested on all connector node tests.
Notes for the reviewer
After hundreds of Crawler instances being created, there are hundreds of zombie processes left behind. This leads to huge wasted memory being consumed by unused processes.
Checklist