feat: Early stopping can be used in Reader and Retriever training#3071
Merged
feat: Early stopping can be used in Reader and Retriever training#3071
Conversation
sjrl
added
type:feature
agnieszka-m
requested changes
Aug 22, 2022
…lyStopping to training Dense retrievers.
brandenchan
suggested changes
Aug 22, 2022
Contributor
brandenchan
left a comment
brandenchan
left a comment
There was a problem hiding this comment.
Making a set of suggestions for improvements to the docstrings
sjrl
commented
Aug 22, 2022
Co-authored-by: Branden Chan <33759007+brandenchan@users.noreply.github.com>
Co-authored-by: Branden Chan <33759007+brandenchan@users.noreply.github.com>
Co-authored-by: Branden Chan <33759007+brandenchan@users.noreply.github.com>
Co-authored-by: Branden Chan <33759007+brandenchan@users.noreply.github.com>
Co-authored-by: Branden Chan <33759007+brandenchan@users.noreply.github.com>
Co-authored-by: Branden Chan <33759007+brandenchan@users.noreply.github.com>
Co-authored-by: Branden Chan <33759007+brandenchan@users.noreply.github.com>
Co-authored-by: Branden Chan <33759007+brandenchan@users.noreply.github.com>
Contributor
Author
|
@bogdankostic This PR is ready for review :) |
bogdankostic
approved these changes
Aug 23, 2022
Contributor
bogdankostic
left a comment
bogdankostic
left a comment
There was a problem hiding this comment.
Looking good to me! I assume you moved EarlyStopping to utils/early_stopping.py for documentation?
Contributor
Author
That is correct! |
Contributor
Author
|
@brandenchan @agnieszka-m I would appreciate another review and an approval if you are happy with the changes. |
brandenchan
approved these changes
Aug 23, 2022
agnieszka-m
approved these changes
Aug 23, 2022
sjrl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
No issue
Proposed Changes:
Add option to specify Early Stopping in the Reader trainer. This feature is already present, I just exposed the option to the
FARMReader.trainmethod.How did you test it?
I've run a Reader training using Early Stopping on AWS and it worked as expected.
Notes for the reviewer
Checklist