Skip to content

bug: adapt UI random question for streamlit 1.12 and pin to streamlit>=1.9.0#3121

Merged
masci merged 2 commits intodeepset-ai:mainfrom
anakin87:fix_ui_for_streamlit_1_12
Aug 31, 2022
Merged

bug: adapt UI random question for streamlit 1.12 and pin to streamlit>=1.9.0#3121
masci merged 2 commits intodeepset-ai:mainfrom
anakin87:fix_ui_for_streamlit_1_12

Conversation

@anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • Check if streamlit has scriptrunner attribute --> streamlit<1.12.0 --> old behavior is ok.
    Otherwise --> streamlit>=1.12.0 --> use the new runtime attribute.

  • I also pinned streamlit>=1.9.0 in setup.py, because, after the changes in Update scriptrunner module path for streamlit ui #2566, the webapp is not compatible with streamlit<1.9.0 (I verified that it raises an exception with 1.8.0)

How did you test it?

Manual verification

Checklist

@anakin87 anakin87 requested a review from a team as a code owner August 29, 2022 20:41
@anakin87 anakin87 requested review from masci and removed request for a team August 29, 2022 20:41
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, should I redeploy the demo after merging this?

@anakin87
Copy link
Member Author

Hey @masci!
Maybe the question isn't aimed at me.
In fact, I don't know the details of the demo deployment...

However, I try to add some details:
for now the demo works (it uses Streamlit 1.11.1) and will continue to work until version 1.12.0 is installed (this may happen automatically). This PR fixes this future bug.

@masci
Copy link
Contributor

masci commented Aug 31, 2022

@anakin87 thanks for the insights, that's what I was looking for. I double checked the workflow and the demo will be redeployed once merged with streamlit bumped to latest 1.x, I'll redeploy and keep an eye on it in case something unrelated to this PR pops up.

@masci masci merged commit e7771dc into deepset-ai:main Aug 31, 2022
@anakin87 anakin87 deleted the fix_ui_for_streamlit_1_12 branch August 31, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamlit 1.12.0 breaks UI random question

2 participants