bug: adapt UI random question for streamlit 1.12 and pin to streamlit>=1.9.0#3121
Merged
masci merged 2 commits intodeepset-ai:mainfrom Aug 31, 2022
anakin87:fix_ui_for_streamlit_1_12
Merged
bug: adapt UI random question for streamlit 1.12 and pin to streamlit>=1.9.0#3121masci merged 2 commits intodeepset-ai:mainfrom anakin87:fix_ui_for_streamlit_1_12
masci merged 2 commits intodeepset-ai:mainfrom
anakin87:fix_ui_for_streamlit_1_12
Conversation
masci
approved these changes
Aug 31, 2022
Contributor
masci
left a comment
There was a problem hiding this comment.
Changes LGTM, should I redeploy the demo after merging this?
Member
Author
|
Hey @masci! However, I try to add some details: |
Contributor
|
@anakin87 thanks for the insights, that's what I was looking for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Check if
streamlithasscriptrunnerattribute -->streamlit<1.12.0 --> old behavior is ok.Otherwise -->
streamlit>=1.12.0 --> use the newruntimeattribute.I also pinned
streamlit>=1.9.0 in setup.py, because, after the changes in Update scriptrunner module path for streamlit ui #2566, the webapp is not compatible withstreamlit<1.9.0 (I verified that it raises an exception with 1.8.0)How did you test it?
Manual verification
Checklist