Skip to content

docs: add tests types to CONTRIBUTING.md#3158

Merged
ZanSara merged 2 commits intomainfrom
massi/test-types
Sep 5, 2022
Merged

docs: add tests types to CONTRIBUTING.md#3158
ZanSara merged 2 commits intomainfrom
massi/test-types

Conversation

@masci
Copy link
Copy Markdown
Contributor

@masci masci commented Sep 5, 2022

Related Issues

Proposed Changes:

Add to the dev docs the outcome of #2811
Ideally, newly added tests will follow those requirements while we progressively adapt the existing tests to the new model.

Checklist

Add the outcome of #2811 to the developers docs

Ideally, newly added tests will follow those requirements while we progressively adapt the existing tests to the new model.
@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 5, 2022
@masci masci requested review from a team as code owners September 5, 2022 11:00
@masci masci requested review from ZanSara and removed request for a team September 5, 2022 11:00
@ZanSara
Copy link
Copy Markdown
Contributor

ZanSara commented Sep 5, 2022

Looks good! I wonder, though, if we should translate these categories into some more practical guidelines for contributors, for example about using the @pytest.integration marker, or creating a new (for now empty) folder for e2e tests where contributors can add their large tests already. Or at least a hint about why there's no match in the actual tests folder for these new groups (something like NOTE: migration of the old tests into these new categories is in progress. Please ask the maintainers if you are in doubt about how to classify your tests or where to place them.)

Copy link
Copy Markdown
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ZanSara ZanSara merged commit e211064 into main Sep 5, 2022
@ZanSara ZanSara deleted the massi/test-types branch September 5, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants