fix: proper retrieval of answers for batch eval#3245
Merged
vblagoje merged 2 commits intodeepset-ai:mainfrom Sep 20, 2022
vblagoje:fix_bath_eval
Merged
fix: proper retrieval of answers for batch eval#3245vblagoje merged 2 commits intodeepset-ai:mainfrom vblagoje:fix_bath_eval
vblagoje merged 2 commits intodeepset-ai:mainfrom
vblagoje:fix_bath_eval
Conversation
Member
Author
|
@bglearning and @masci let me know what you guys think. Would you also please run the existing manual tests that fail? |
masci
approved these changes
Sep 20, 2022
Contributor
masci
left a comment
There was a problem hiding this comment.
I think that piece of code should be refactored a bit but for the scope of this PR it's better to keep the diff small, so it's 👍 from my side.
I tested your branch on Tutorial 15 in colab and it works.
Contributor
|
@vblagoje Just realized the error that Miriam had was from a different line which has a similar faulty pattern. Specifically this one base.py#L1610 if documents is not None:
if isinstance(documents[i], list): # Index out of range with this
documents = documents[i]
if len(documents) == 0:
...Maybe best to also update that line too. |
Member
Author
|
@bglearning added your fix, please verify. If all is good, please integrate as well. |
brandenchan
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Proper retrieval of answers and documents for batch eval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Improper list access. Fixed the list access
How did you test it?
TODO
Notes for the reviewer
Please review carefully and run the previous failing tests
Checklist