fix: MostSimilarDocumentsPipeline doesn't have pipeline property#3265
Merged
vblagoje merged 2 commits intodeepset-ai:mainfrom Sep 23, 2022
vblagoje:document_search_pipeline_fix
Merged
fix: MostSimilarDocumentsPipeline doesn't have pipeline property#3265vblagoje merged 2 commits intodeepset-ai:mainfrom vblagoje:document_search_pipeline_fix
vblagoje merged 2 commits intodeepset-ai:mainfrom
vblagoje:document_search_pipeline_fix
Conversation
vblagoje
requested review from
ZanSara and
bogdankostic
and removed request for
a team and
ZanSara
vblagoje
changed the title
bogdankostic
approved these changes
Sep 23, 2022
masci
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
MostSimilarDocumentsPipeline, unlike all other pipelines, doesn't have the underlying pipeline property/field. Any method from the superclass that relies on pipeline (get_type, save_to_yaml) will fail.
I added pipeline property, added document store to pipeline but I left the run methods as is - I don't think we can use BaseDocumentStore run method. @bogdankostic please confirm.
How did you test it?
Added a unit test for pipeline classification
Notes for the reviewer
Should we add unit tests that exercise other BaseStandardPipeline methods that rely on the pipeline?
Checklist