fix: allow same vector_id in different indexes for SQL-based Document stores#3383
Merged
ZanSara merged 2 commits intodeepset-ai:mainfrom Oct 14, 2022
anakin87:fix_multiple_indexes_for_FAISSDocumentStore
Merged
fix: allow same vector_id in different indexes for SQL-based Document stores#3383ZanSara merged 2 commits intodeepset-ai:mainfrom anakin87:fix_multiple_indexes_for_FAISSDocumentStore
vector_id in different indexes for SQL-based Document stores#3383ZanSara merged 2 commits intodeepset-ai:mainfrom
anakin87:fix_multiple_indexes_for_FAISSDocumentStore
Conversation
ZanSara
approved these changes
Oct 14, 2022
Contributor
ZanSara
left a comment
There was a problem hiding this comment.
Spot on! No remarks, this is good to go right away. Thank you! 😊
vector_id in different indexes for SQL-based Document storesvector_id in different indexes for SQL-based Document stores
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
In
SQLDocumentStore:vector_idis no longer uniqueUniqueConstraintforindex+vector_idIn
FAISSDocumentStore:update_embeddingsmethod to take this change into account.Now for every index,
vector_idstarts at 0How did you test it?
pytest . --document_store_type="sql,faiss"SQLDocumentStoreandFAISSDocumentStoreNotes for the reviewer
Checklist