Skip to content

fix: Update env variable for model caching timeout#3405

Merged
sjrl merged 2 commits intomainfrom
sjrl-patch-1
Oct 18, 2022
Merged

fix: Update env variable for model caching timeout#3405
sjrl merged 2 commits intomainfrom
sjrl-patch-1

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Oct 18, 2022

The environment variable used to set the timeout for the model caching step had a typo in it from the maintainers of actions/cache@v3, which is why it has not been working (see comment here).

Related Issues

Proposed Changes:

Fix the typo in the variable name.

How did you test it?

No easy way to test. We need to wait for a scenario where the timeout will kick in during the CI

Checklist

The environment variable used to set the timeout for the model caching step had a typo in it from the maintainers of `actions/cache@v3`, which is why it has not been working (see comment [here](actions/cache#810 (comment))).
@sjrl sjrl requested a review from a team as a code owner October 18, 2022 07:07
@sjrl sjrl requested review from bogdankostic and removed request for a team October 18, 2022 07:07
@sjrl sjrl added type:bug Something isn't working topic:CI labels Oct 18, 2022
@sjrl sjrl requested a review from vblagoje October 18, 2022 10:56
@sjrl
Copy link
Contributor Author

sjrl commented Oct 18, 2022

Hey @vblagoje I would appreciate a review of this when you have the chance :) Hopefully this brings to a close the HF model caching issue.

@sjrl sjrl merged commit 51d4fe0 into main Oct 18, 2022
@sjrl sjrl deleted the sjrl-patch-1 branch October 18, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:CI type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants