feat: Create the TextIndexingPipeline#3473
Merged
brandenchan merged 5 commits intomainfrom Nov 1, 2022
Merged
Conversation
ZanSara
reviewed
Oct 25, 2022
Contributor
ZanSara
left a comment
There was a problem hiding this comment.
Just an idea to make it a bit more flexible! Looking great in general, thanks for this PR 😊
ZanSara
approved these changes
Oct 31, 2022
…ck into text_indexing_pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
test_standard_pipelines.pyin thetestfolder but the tests within them don't seem to import any of the standard pipelines fromhaystack/pipelines/standard_pipelines.pyChecklist