Skip to content

feat: Create the TextIndexingPipeline#3473

Merged
brandenchan merged 5 commits intomainfrom
text_indexing_pipeline
Nov 1, 2022
Merged

feat: Create the TextIndexingPipeline#3473
brandenchan merged 5 commits intomainfrom
text_indexing_pipeline

Conversation

@brandenchan
Copy link
Contributor

Related Issues

Proposed Changes:

  • Create the TextIndexingPipeline so that we can show users how to index Documents using Pipelines (rather than utility functions) while also abstracting away the complexity of initialising a Pipeline object.

How did you test it?

  • Manual testing

Notes for the reviewer

  • How should this be tested for? I see there is a test_standard_pipelines.py in the test folder but the tests within them don't seem to import any of the standard pipelines from haystack/pipelines/standard_pipelines.py

Checklist

@brandenchan brandenchan requested a review from a team as a code owner October 25, 2022 11:48
@brandenchan brandenchan requested review from masci and removed request for a team October 25, 2022 11:48
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea to make it a bit more flexible! Looking great in general, thanks for this PR 😊

@masci masci requested review from ZanSara and removed request for masci October 31, 2022 12:07
@ZanSara ZanSara marked this pull request as draft October 31, 2022 15:46
@ZanSara ZanSara marked this pull request as ready for review October 31, 2022 15:46
@brandenchan brandenchan merged commit 0b2e71d into main Nov 1, 2022
@brandenchan brandenchan deleted the text_indexing_pipeline branch November 1, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:DX Developer Experience topic:indexing topic:pipeline type:feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants