fix: do not reference package directory in PDFToTextOCRConverter.convert()

[ZanSara]

Related Issues

• fixes PDFToTextOCRConverter.convert() write temp files into the package folder #3477

Proposed Changes:

• Remove path referencing the package folder from

  haystack/haystack/nodes/file_converter/pdf.py

  Line 255 in 5ca9635

  temp_img = tempfile.NamedTemporaryFile(dir=os.path.dirname(os.path.realpath(__file__)), suffix=".jpeg")

• This path causes issues if the package folder is not writable (non editable installs with Conda on Windows, just to name an example)

How did you test it?

• CI

Notes for the reviewer

n/a

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added tests that demonstrate the correct behavior of the change
• I've used the conventional commit convention for my PR title
• I documented my code
• I ran pre-commit hooks and fixed any issue

[vblagoje]

@ZanSara seems a bit confusing about what is going on here. It seems like some knowledge is lost between the lines. Perhaps a small comment to explain what is going on?

[vblagoje]

LGTM