feat: include error message in HaystackError telemetry events#3543
Merged
julian-risch merged 6 commits intodeepset-ai:mainfrom Nov 10, 2022
vblagoje:telemetry_error
Merged
feat: include error message in HaystackError telemetry events#3543julian-risch merged 6 commits intodeepset-ai:mainfrom vblagoje:telemetry_error
julian-risch merged 6 commits intodeepset-ai:mainfrom
vblagoje:telemetry_error
Conversation
Member
|
@vblagoje I committed the small changes that we discussed. In addition, one could add the |
julian-risch
approved these changes
Nov 9, 2022
Member
There was a problem hiding this comment.
LGTM! 👍 @vblagoje please also review the changes, thank you. Feel free to merge when you are done with your review.
Member
Author
|
Yes, LGTM as well. If CI is green, let's integrate it! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Added a message field to all HaystackError(s) raised. If set message property will be visible in telemetry
How did you test it?
Manual verification, there is no other way.
Notes for the reviewer
Someone familiar with telemetry needs to review. Otherwise, the context is rather big and requires time to pick up.
Checklist